Add sound effects #108
Add sound effects #108
Conversation
|
PD: I changed the cursor sound |
src/menu/menu.c
Outdated
| mixer_ch_set_vol(SFX_CHANNEL, 0.5f, 0.5f); | ||
| wav64_open(&sfx_cursor, "rom:/cursorsound.wav64"); | ||
| wav64_open(&sfx_exit, "rom:/back.wav64"); | ||
| wav64_open(&sfx_settings, "rom:/settings.wav64"); | ||
| wav64_open(&sfx_enter, "rom:/enter.wav64"); | ||
| wav64_open(&sfx_error, "rom:/error.wav64"); | ||
|
|
There was a problem hiding this comment.
This can be moved into sound_reconfigure. Don't forget about a flag to do loading only once.
There was a problem hiding this comment.
I have done what I can to make this better, but might be a better way. Please let us know.
|
I extracted the sounds from the web that networkfusion recommended. I readed the rules and apparently all sounds in that page are free. If you want to check it out: https://pixabay.com/es/service/license-summary/ |
|
Nice work. I would suggest also updating the readme with the "notable feature" list and adding the source of the wav files (and their names/creator) to the "Open source software and licenses used" list. |
|
I have been messing around with this, but not tested... My current state is https://github.com/networkfusion/N64FlashcartMenu/tree/refactor-sfx. Feel free to use it! |
…cartMenu into sound-effects
Add fs sounds to git ignore
|
@Suprapote here are a few more changes to complete the refactor: Suprapote#1 |
TODO: requires the blanks filling in.
Finish refactoring sound effects PR
|
I deleted the last two because I extracted them from the actions sound |
In that case, probably better to update the action sound entry to state it is also for the other ones used. |
Actually, after re-reading, probably fine. |
|
Okay, I think I have done all I can to help with this PR 😅 . Hopefully my help has been useful and it helps understanding of the codebase and what is expected by your many future PR's @Suprapote 😁 . |
|
Yes, thank you for your help 😁 |
|
Final result: 2024-06-05.20-12-01.mp4 |
| if (menu->settings.sound_enabled) { | ||
| sound_init_sfx(); | ||
| } |
There was a problem hiding this comment.
Minor nitpick because changing this setting live will not enable sounds and will require complete reboot of the menu. It's okay for now because we don't have a settings editor yet.
Description
Adding sound for make the navigation not so borring.
Motivation and Context
This issue
How Has This Been Tested?
Screenshots
MKV.to.MP4.Converter.-.FreeConvert.com.mp4
Types of changes
Checklist:
Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>