Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(phi0119)_title_review #530

Merged
merged 4 commits into from
Jun 7, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions data/phi0119/phi006/__cts__.xml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<ti:work xmlns:ti="http://chs.harvard.edu/xmlns/cts" urn="urn:cts:latinLit:phi0119.phi006" xml:lang="lat" groupUrn="urn:cts:latinLit:phi0119">
<ti:title xml:lang="lat">Casina</ti:title>
<ti:translation xml:lang="eng" urn="urn:cts:latinLit:phi0119.phi006.perseus-eng2" workUrn="urn:cts:latinLit:phi0119.phi006">
<ti:label xml:lang="eng">Casina, or The Stratagem Defeated</ti:label>
<ti:description xml:lang="eng">Plautus, Titus Maccius, creator; Riley, H. T. (Henry Thomas), 1816-1878, translator</ti:description>
<ti:label xml:lang="mul">Casina, or The Stratagem Defeated</ti:label>
<ti:description xml:lang="eng">Plautus Riley, H. T. , translator</ti:description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @lcerrato. Yeah that's just because I had started to change out the ti:descriptions and was eliminating extraenous info using find and replace across the files. I was going to do a second pull request with all the bibliographic info in the cts_.xml files changed on Monday and so forth with the other changes in Plautus. But I can fix it here before you approve if you like!

</ti:translation>
<ti:edition urn="urn:cts:latinLit:phi0119.phi006.perseus-lat2" workUrn="urn:cts:latinLit:phi0119.phi006">
<ti:label xml:lang="lat">Casina</ti:label>
<ti:description xml:lang="eng">Plautus, Titus Maccius, creator; Leo, Friedrich, 1851-1914, editor</ti:description>
<ti:description xml:lang="eng">Plautus Leo, Friedrich,Riley, H. T. editor</ti:description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected space and two names merged?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Friedrich or Riley? Looks like the find/replace added Riley here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @lcerrato I thought I had caught that but like I said this second set of changes I had just started and was really only wanting to have the titles reviewed here.

</ti:edition>
</ti:work>
6 changes: 3 additions & 3 deletions data/phi0119/phi009/phi0119.phi009.perseus-eng2.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
<teiHeader>
<fileDesc>
<titleStmt>
<title>Epidicus, or The Fortunate Discovery</title>
<title xml:Lang-="mul">Epidicus, or The Fortunate Discovery</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two errors here xml:Lang-= instead of xml:lang=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah @lcerrato this is what happens when I don't change the Schema to automatically validate.

<author>T. Maccius Plautus</author>
<editor role="transl">Henry Thomas Riley</editor>
<editor role="translator">Henry Thomas Riley</editor>
<sponsor>Perseus Project, Tufts University</sponsor>
<principal>Gregory Crane</principal>
<respStmt>
Expand All @@ -26,7 +26,7 @@
<biblStruct>
<monogr>
<title>The Comedies of Plautus</title>
<editor role="transl">Henry Thomas Riley</editor>
<editor role="translator">Henry Thomas Riley</editor>
<imprint>
<pubPlace>London</pubPlace>
<publisher>G. Bell and Sons</publisher>
Expand Down