-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(phi0119)_title_review #530
Conversation
Re #464 Updated languages in cts_.xml files, added in English translations for consistency with cts_.xml files and TEI-XML files. Next pass will add volume level metadata to the cts_.xml files. Signed-off-by: Alison Babeu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor language inconsistencies
data/phi0119/phi006/__cts__.xml
Outdated
@@ -1,11 +1,11 @@ | |||
<ti:work xmlns:ti="http://chs.harvard.edu/xmlns/cts" urn="urn:cts:latinLit:phi0119.phi006" xml:lang="lat" groupUrn="urn:cts:latinLit:phi0119"> | |||
<ti:title xml:lang="lat">Casina</ti:title> | |||
<ti:translation xml:lang="eng" urn="urn:cts:latinLit:phi0119.phi006.perseus-eng2" workUrn="urn:cts:latinLit:phi0119.phi006"> | |||
<ti:label xml:lang="eng">Casina, The comedies of Plautus Vol II</ti:label> | |||
<ti:label xml:lang="eng">Casina, or The Stratagem Defeated</ti:label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you used "multiple" elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw those I will fix. And you are quite right @lcerrato this is a much more efficient way to get reviews.
@@ -2,7 +2,7 @@ | |||
<teiHeader> | |||
<fileDesc> | |||
<titleStmt> | |||
<title>Epidicus, or The Fortunate Discovert</title> | |||
<title>Epidicus, or The Fortunate Discovery</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used multiple above
…ted going ahead with other changes. Signed-off-by: Alison Babeu <[email protected]>
data/phi0119/phi006/__cts__.xml
Outdated
<ti:label xml:lang="eng">Casina, or The Stratagem Defeated</ti:label> | ||
<ti:description xml:lang="eng">Plautus, Titus Maccius, creator; Riley, H. T. (Henry Thomas), 1816-1878, translator</ti:description> | ||
<ti:label xml:lang="mul">Casina, or The Stratagem Defeated</ti:label> | ||
<ti:description xml:lang="eng">Plautus Riley, H. T. , translator</ti:description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @lcerrato. Yeah that's just because I had started to change out the ti:descriptions and was eliminating extraenous info using find and replace across the files. I was going to do a second pull request with all the bibliographic info in the cts_.xml files changed on Monday and so forth with the other changes in Plautus. But I can fix it here before you approve if you like!
data/phi0119/phi006/__cts__.xml
Outdated
</ti:translation> | ||
<ti:edition urn="urn:cts:latinLit:phi0119.phi006.perseus-lat2" workUrn="urn:cts:latinLit:phi0119.phi006"> | ||
<ti:label xml:lang="lat">Casina</ti:label> | ||
<ti:description xml:lang="eng">Plautus, Titus Maccius, creator; Leo, Friedrich, 1851-1914, editor</ti:description> | ||
<ti:description xml:lang="eng">Plautus Leo, Friedrich,Riley, H. T. editor</ti:description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected space and two names merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this Friedrich or Riley? Looks like the find/replace added Riley here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @lcerrato I thought I had caught that but like I said this second set of changes I had just started and was really only wanting to have the titles reviewed here.
@@ -2,9 +2,9 @@ | |||
<teiHeader> | |||
<fileDesc> | |||
<titleStmt> | |||
<title>Epidicus, or The Fortunate Discovery</title> | |||
<title xml:Lang-="mul">Epidicus, or The Fortunate Discovery</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two errors here xml:Lang-=
instead of xml:lang=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah @lcerrato this is what happens when I don't change the Schema to automatically validate.
@AlisonBabeu |
hey @lcerrato I think it is that I was just replacing some info. There will be volume information in between Plautus and the editors name, and that won't be a find and replace because I'll be double checking it with each work since that info is only in the catalog not the TEI-XML file. |
Second pull request updating all of the cts_.xml files to standard citation format.
Re #464
Updated languages in cts_.xml files, added in English translations for consistency with cts_.xml files and TEI-XML files.
Next pass will add volume level metadata to the cts_.xml files.