-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(phi0474.phi001).perseus-lat2_perseus-eng2 #452
Conversation
First attempt at changes Changed the cts work title to the Latin title. Updated both the title and edition descriptions to current standards. Updated headers and bibliographic info. Changed M. Tullius Cicero per earlier conversation on author names, but may have misinterpreted.
@AlisonBabeu |
@AlisonBabeu Pull from master and then push to this branch before proceeding. That should fix the tests and repair our broken builds. |
data/phi0474/phi001/__cts__.xml
Outdated
|
||
|
||
<ti:edition workUrn="urn:cts:latinLit:phi0474.phi001" urn="urn:cts:latinLit:phi0474.phi001.perseus-lat2" xml:lang="lat"> | ||
<ti:label xml:lang="lat">Pro P. Quinctio</ti:label> | ||
<ti:description xml:lang="mul">Cicero. M. Tulli Ciceronis. Orationes, Vol. IV. Clark, Albert Curtis, editor. Oxford: Clarendon Press, 1909.</ti:description> | ||
<ti:description xml:lang="mul">Cicero, Marcus Tullius. M. Tulli Ciceronis. Orationes, Vol. IV. Clark, Albert Curtis, editor. Oxford: Clarendon Press, 1909.</ti:description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just use the short common name here. We just want a short version to tell the user the author when the author's name is in Latin or Greek, etc.
Cicero. M. Tulli Ciceronis. Orationes, Vol. IV. Clark, Albert Curtis, editor. Oxford: Clarendon Press, 1909.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
data/phi0474/phi001/__cts__.xml
Outdated
<ti:label xml:lang="eng">For Publius Quinctius, The orations of Marcus Tullius Cicero Vol. 1 Orations for Quintius, Sextus Roscius, Quintus Roscius, against Quintus Cæcilius, and against Verres</ti:label> | ||
<ti:description xml:lang="eng">Cicero, Marcus Tullius, creator; Yonge, Charles Duke, 1812-1891, translator</ti:description> | ||
<ti:label xml:lang="eng">For Publius Quinctius</ti:label> | ||
<ti:description xml:lang="eng">Cicero, Marcus Tullius. The Orations of Marcus Tullius Cicero, Volume 1. Yonge, Charles Duke, translator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
<author>M. Tullius Cicero</author> | ||
<title>The Orations of Marcus Tullius Cicero, literally translated by C. D. | ||
Yonge</title><idno type="OCLC">4709897</idno> | ||
<author>Cicero</author> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it's the opposite. The book gives his full name, so the author name should match the book.
The purpose of a short common name in the cts metadata description is to avoid confusion when the name(s) is/are in different languages or transliteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reread your comments this morning on Claudian after submitting this pull request and I actually do get what you meant there, about how the name shows up in the book. In the Claudian book they list Claudian so I left it that way. I hadn't looked at the printed Cicero texts but will start looking at all scanned texts before I change names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlisonBabeu
I think all of the Latin and all of the English are from only a couple of editions/series. So it would probably be best to just pick one for each of these types of items (top level author, monograph author) apply it en masse for the Cicero corpus.
The irony being that we are still stuck with an unsophisticated TOC in the reading environment, so that none of this helps in the context of the Scaife Viewer. (sigh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other words, the consistency is more important than reproducing precisely what each print volume calls him. I'd rather have all of the files use the same darn <author>
name in the same order and with the same abbreviation formulation here.
<title type="sub">Machine readable text</title> | ||
<author>M. Tullius Cicero</author> | ||
<editor role="translator" n="Yonge">C. D. Yonge</editor> <sponsor>Perseus Project, Tufts University</sponsor> | ||
<author>Cicero</author> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name should match the name you want as the canonical name. So it could be Cicero or M. Tullius Cicero — I don't know if we chose one over the other. Usually, I have the catalog name here.
<author>M. Tullius Cicero</author> | ||
<editor role="editor" n="OCT">Albert Clark</editor> | ||
<title>Pro P. Quinctio</title> | ||
<author>Cicero</author> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
@@ -39,17 +37,21 @@ | |||
<biblStruct> | |||
<monogr> | |||
<author>M. Tullius Cicero</author> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good but it's different from the other file.
@AlisonBabeu For the cts work metadata description only it should always read: For the top level text file For the monograph author, that will usually be directly from the catalog/worldcat data or the print edition. I do not think we are consistent about First, Last or Last, First. I usually do it First, Last for the sake of readability, but others may not do that. (I figure that the catalog is always going to have more fulsome and complete data anyhow so this is just a short finding aid.) The textgroup name should be just as you want it to appear in the TOC. So that is where Cicero, Marcus Tullius or Cicero, M. Tullius is best. |
hey @lcerrato believe it or not I think I do finally understand what I'm doing. I had actually left the top level textgroup as Cicero since that is how it appeared, but I think I will go with Cicero, Marcus Tullius. I will use M. Tullius Cicero in the files as is your suggestion and will check scanned volumes from now on to make sure author name in the monograph section reflect the printed volume. Off to edit! |
Finally updating per request. Updated textgroup to Cicero, Marcus Tullius Standardized author name in headers and structured bibls Added in some missing language tags.
First attempt at changes re #448
Changed the cts work title to the Latin title.
Updated both the title and edition descriptions to current standards.
Updated headers and bibliographic info.
Changed M. Tullius Cicero per earlier conversation on author names, but may have misinterpreted.