Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module/lb_external): Setting balancing_mode = CONNECTION due to provider changes #37

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions modules/lb_external/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@
- Can only use the nic0 (the base interface) of an instance.
- Cannot serve as a next hop in a GCP custom routing table entry.

## Limitation

### Supported Module Version with Regards to the Changed Provider's Default Values

- Module versions `<=2.0.6` supports `terraform-provider-google` version `<6.0`. If you are using `terraform-provider-google` version `6.0` and above choose module version `2.0.7` and above. This limitation is related to the [change](https://github.com/hashicorp/terraform-provider-google/commit/267f964bd4f2d9b48e8771c2a8397de3f6655ef7) in the default value of `balancing_mode` introduced in the `terraform-provider-google` version `6.0`

## Reference
<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
### Requirements
Expand Down
3 changes: 2 additions & 1 deletion modules/lb_external/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ resource "google_compute_region_backend_service" "this" {
dynamic "backend" {
for_each = var.backend_instance_groups
content {
group = backend.value
group = backend.value
balancing_mode = "CONNECTION"
}
}

Expand Down
Loading