Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module/lb_external): Setting balancing_mode = CONNECTION due to provider changes #37

Closed

Conversation

pavelrn
Copy link
Contributor

@pavelrn pavelrn commented Sep 12, 2024

Description

Set google_compute_region_backend_service balancing_mode = "CONNECTION" explicitly due to the change in the terraform-provider-google version 6.0+

Motivation and Context

Resolves #34

How Has This Been Tested?

Create a load balancer as part of Common architecture.

Screenshots (if appropriate)

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@pavelrn pavelrn requested a review from a team as a code owner September 12, 2024 18:49
@pavelrn pavelrn linked an issue Sep 12, 2024 that may be closed by this pull request
@pavelrn pavelrn self-assigned this Sep 12, 2024
@pavelrn pavelrn added the bug Something isn't working label Sep 12, 2024
@pavelrn pavelrn changed the title fix(module/lb_external): Setting google_compute_region_backend_service/balancing_mode due to provider changes fix(module/lb_external): Setting balancing_mode = CONNECTION due to provider changes Sep 12, 2024
@lstadnik
Copy link
Contributor

It was addressed in PR #39

@pavelrn pavelrn closed this Sep 13, 2024
@pavelrn pavelrn deleted the 34-lb-module-not-setting-balancing-mode-correctly branch September 13, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LB module not setting balancing mode correctly.
2 participants