-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed enable_avoid_dynamic_calls #2312
fixed enable_avoid_dynamic_calls #2312
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
Shouldn't you also include the updated |
@palisadoes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2312 +/- ##
===========================================
+ Coverage 93.64% 94.93% +1.29%
===========================================
Files 157 157
Lines 7533 7538 +5
===========================================
+ Hits 7054 7156 +102
+ Misses 479 382 -97 ☔ View full report in Codecov by Sentry. |
Thanks. Please work with the assigned reviewers to approve your approach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing docs properly. Please do these minor changes.
test/view_model_tests/pre_auth_view_models/login_view_model_test.dart
Outdated
Show resolved
Hide resolved
@literalEval @Ayush0Chaudhary @DMills27 @noman2002 kindly review this PR. |
Please fix the doc as suggested now |
@literalEval please have a look i have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure that every doc (and possibly code too), is in the range of 80 characters per line max.
@Azad99-9 please do this quick change. |
Sure @literalEval |
@literalEval please have a look, I have updated the comments length. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What kind of change does this PR introduce?
This PR fixes the issue enable_avoid_dynamic_calls
Issue Number:
Fixes #1721
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
removed the
ignore directive : avoid_dynamic_call
from the codebase and fixed the consequential warnings.Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes