Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed enable_avoid_dynamic_calls #2312

Merged
merged 19 commits into from
Jan 11, 2024
Merged

fixed enable_avoid_dynamic_calls #2312

merged 19 commits into from
Jan 11, 2024

Conversation

Azad99-9
Copy link
Contributor

@Azad99-9 Azad99-9 commented Jan 7, 2024

What kind of change does this PR introduce?

This PR fixes the issue enable_avoid_dynamic_calls

Issue Number:

Fixes #1721

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

removed theignore directive : avoid_dynamic_call from the codebase and fixed the consequential warnings.

Does this PR introduce a breaking change?

No

Other information

Have you read the contributing guide?

Yes

Copy link

github-actions bot commented Jan 7, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@palisadoes
Copy link
Contributor

Shouldn't you also include the updated analysis_options.yaml file?

@Azad99-9
Copy link
Contributor Author

Azad99-9 commented Jan 7, 2024

@palisadoes
actually the analysis_options.yaml file is already updated in this PR.
So now the task of the issue has boiled down to remove the ignore_directives from the entire codebase and fix the respective warnings.

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (705627f) 93.64% compared to head (944a0c4) 94.93%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2312      +/-   ##
===========================================
+ Coverage    93.64%   94.93%   +1.29%     
===========================================
  Files          157      157              
  Lines         7533     7538       +5     
===========================================
+ Hits          7054     7156     +102     
+ Misses         479      382      -97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes
Copy link
Contributor

Thanks. Please work with the assigned reviewers to approve your approach

Copy link
Member

@literalEval literalEval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing docs properly. Please do these minor changes.

@Azad99-9 Azad99-9 requested a review from literalEval January 9, 2024 13:44
@Azad99-9
Copy link
Contributor Author

Azad99-9 commented Jan 10, 2024

@literalEval @Ayush0Chaudhary @DMills27 @noman2002 kindly review this PR.

@literalEval
Copy link
Member

Please fix the doc as suggested now

@Azad99-9
Copy link
Contributor Author

@literalEval please have a look i have reformatted the docs.

Copy link
Member

@literalEval literalEval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that every doc (and possibly code too), is in the range of 80 characters per line max.

@literalEval
Copy link
Member

@Azad99-9 please do this quick change.

@Azad99-9
Copy link
Contributor Author

Sure @literalEval

@Azad99-9
Copy link
Contributor Author

@literalEval please have a look, I have updated the comments length.

@Azad99-9 Azad99-9 requested a review from literalEval January 11, 2024 15:04
Copy link
Member

@literalEval literalEval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palisadoes palisadoes merged commit dce8ce0 into PalisadoesFoundation:develop Jan 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling avoid_dynamic_calls in analysis_options.yaml
3 participants