Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling avoid_dynamic_calls for post related functionalities #1761

Closed
Amogh35 opened this issue Apr 9, 2023 · 9 comments
Closed

Enabling avoid_dynamic_calls for post related functionalities #1761

Amogh35 opened this issue Apr 9, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@Amogh35
Copy link
Contributor

Amogh35 commented Apr 9, 2023

Describe the bug
We need to re-enable the avoid_dynamic_calls check and fix the resulting bugs. However since the bugs are highly sensitive, we are creating multiple issues for different functionalities so that it becomes easier to spot any unforeseen problems.

To Reproduce
Run the current suite of tests, and they all pass. This is because the avoid_dynamic_calls check has been disabled

Expected behavior
avoid_dynamic_calls must be re-enabled, and all the resulting errors must be fixed.

Actual behavior
avoid_dynamic_calls is currently disabled.

Additional details
This is a sub-part of issue #1721 for all the post-related bugs.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship #359

@Amogh35 Amogh35 added the bug Something isn't working label Apr 9, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Apr 9, 2023
@Amogh35
Copy link
Contributor Author

Amogh35 commented Apr 9, 2023

@palisadoes, please assign as I am already done fixing this.

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 20, 2023
@palisadoes
Copy link
Contributor

Unassigned due to inactivity

@github-actions github-actions bot removed the no-issue-activity No issue activity label May 15, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jun 1, 2023
Copy link

This issue did not get any activity in the past 180 days and thus has been closed. Please check if the newest release or develop branch has it fixed. Please, create a new issue if the issue is not fixed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2023
@palisadoes
Copy link
Contributor

Reopening as this is a best practice.

@palisadoes palisadoes reopened this Nov 29, 2023
@github-actions github-actions bot removed the no-issue-activity No issue activity label Nov 30, 2023
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 11, 2023
@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 2, 2024
@Azad99-9
Copy link
Contributor

Azad99-9 commented Jan 8, 2024

@palisadoes this issue is fixed in this PR.

As the ignore_directive : avoid_dynamic_calls has been removed from entire codebase, this issue just becomes the subset of issue #1721

@Azad99-9
Copy link
Contributor

@palisadoes please close this issue as it is already fixed in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants