Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading flutter to the latest stable version v3.16.0 #2140

Merged
merged 12 commits into from
Nov 26, 2023
Merged

Upgrading flutter to the latest stable version v3.16.0 #2140

merged 12 commits into from
Nov 26, 2023

Conversation

Dante291
Copy link
Contributor

What kind of change does this PR introduce?

Upgrading flutter version from 3.13.0 to 3.16.0

Issue Number:

Fixes #2135

Did you add tests for your changes?

No

Have you read the contributing guide?

Yes

@Dante291 Dante291 requested a review from palisadoes as a code owner November 25, 2023 16:04
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@palisadoes
Copy link
Contributor

Please fix the failing codebase test

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9dc3483) 78.99% compared to head (afdc545) 78.96%.
Report is 2 commits behind head on develop.

Files Patch % Lines
...dels/add_post_view_models/add_post_view_model.dart 0.00% 1 Missing ⚠️
...s/profile_view_models/edit_profile_view_model.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2140      +/-   ##
===========================================
- Coverage    78.99%   78.96%   -0.03%     
===========================================
  Files          152      152              
  Lines         7456     7456              
===========================================
- Hits          5890     5888       -2     
- Misses        1566     1568       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dante291
Copy link
Contributor Author

@palisadoes @noman2002 Sir all tests are getting passed but this PR has indirect change on this file due to which overall coverage is affected by 0.03%. The issue is there is no test written for this file, so we could actually merge this and I could write test for that separately.

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@palisadoes palisadoes merged commit 1d4113d into PalisadoesFoundation:develop Nov 26, 2023
3 of 8 checks passed
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
…ndation#2140)

* Upgrading flutter to the latest stable version

* fixing linting errors

* fixing failing tests

* fixing tests

* fixing render overflow bug

* fixing lint errors

* fixing test

* fixing test

* fixing test

* fixing edit event page test

* fixing edit event page test

* fixing edit event page test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the Talawa mobile app to the latest version of Flutter for MVP
3 participants