-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading flutter to the latest stable version v3.16.0 #2140
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
Please fix the failing codebase test |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2140 +/- ##
===========================================
- Coverage 78.99% 78.96% -0.03%
===========================================
Files 152 152
Lines 7456 7456
===========================================
- Hits 5890 5888 -2
- Misses 1566 1568 +2 ☔ View full report in Codecov by Sentry. |
@palisadoes @noman2002 Sir all tests are getting passed but this PR has indirect change on this file due to which overall coverage is affected by 0.03%. The issue is there is no test written for this file, so we could actually merge this and I could write test for that separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
1d4113d
into
PalisadoesFoundation:develop
…ndation#2140) * Upgrading flutter to the latest stable version * fixing linting errors * fixing failing tests * fixing tests * fixing render overflow bug * fixing lint errors * fixing test * fixing test * fixing test * fixing edit event page test * fixing edit event page test * fixing edit event page test
What kind of change does this PR introduce?
Upgrading flutter version from 3.13.0 to 3.16.0
Issue Number:
Fixes #2135
Did you add tests for your changes?
No
Have you read the contributing guide?
Yes