Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update regex to detect all variants of /* istanbul ignore */ comments #3217 #3221

Merged
merged 7 commits into from
Jan 10, 2025
Merged

fix: Update regex to detect all variants of /* istanbul ignore */ comments #3217 #3221

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
243fa54
fix: Update regex to detect all variants of /* istanbul ignore */ com…
khushipatil1523 Jan 9, 2025
0a12679
Update code_coverage_disable_check.py
khushipatil1523 Jan 9, 2025
a8d0a7b
Update code_coverage_disable_check.py
khushipatil1523 Jan 9, 2025
c612d55
fix: Update regex to detect all variants of /* istanbul ignore */ com…
khushipatil1523 Jan 9, 2025
c2ab64a
fix: Update regex to detect all variants of /* istanbul ignore */ com…
khushipatil1523 Jan 9, 2025
5825453
fix: Update regex to detect all variants of /* istanbul ignore */ com…
khushipatil1523 Jan 9, 2025
cc76e26
fix: Update regex to detect all variants of /* istanbul ignore */ com…
khushipatil1523 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/scripts/code_coverage_disable_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Code Coverage Disable Checker Script.

Check warning on line 1 in .github/workflows/scripts/code_coverage_disable_check.py

View workflow job for this annotation

GitHub Actions / Performs linting, formatting, type-checking, checking for different source and target branch 

File ignored by default.

Methodology:

Expand Down Expand Up @@ -38,10 +38,11 @@
otherwise.
"""
code_coverage_disable_pattern = re.compile(
r"""//?\s*istanbul\s+ignore(?:\s+(?:next|-line))?[^\n]*|
/\*\s*istanbul\s+ignore\s+(?:next|-line)\s*\*/""",
r"/\*\s*istanbul\s+ignore.*?\*/|//?\s*istanbul\s+ignore(?:\s+(?:next|-line))?[^\n]*",
re.IGNORECASE,
)


try:
with open(file_path, "r", encoding="utf-8") as file:
content = file.read()
Expand Down
Loading