fix: Update regex to detect all variants of /* istanbul ignore */ comments #3217 #3221
Conversation
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/scripts/code_coverage_disable_check.py(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: PR Workflow
.github/workflows/scripts/code_coverage_disable_check.py
[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify or delete.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyse Code With CodeQL (javascript)
🔇 Additional comments (1)
.github/workflows/scripts/code_coverage_disable_check.py (1)
41-44: Protected file modification requires special labelThe pipeline failure indicates this is a protected file that requires the 'ignore-sensitive-files-pr' label for modification.
Please add the required label to the PR to proceed with the changes.
🧰 Tools
🪛 GitHub Actions: PR Workflow
[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify or delete.
palisadoes
added
the
ignore-sensitive-files-pr
|
Please fix the failing test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3221 +/- ##
=====================================================
+ Coverage 10.78% 90.17% +79.39%
=====================================================
Files 308 330 +22
Lines 7838 8488 +650
Branches 1709 1933 +224
=====================================================
+ Hits 845 7654 +6809
+ Misses 6932 604 -6328
- Partials 61 230 +169 ☔ View full report in Codecov by Sentry. |
Thank you for your feedback. I have made the necessary changes to the script to cover lines that start with /* istanbul and end with */. The issue you referenced from the recent PR has been addressed, and the changes are now in place. Please let me know if there’s anything else you'd like me to adjust. |
|
Please test your work with repo files until completely validated |
I have tested the script with the repo files by running the command python code_coverage_disable_check.py --directory C:\Users\khush\talawa-admin. The script returned the expected results, and I went through the codebase of the listed files in the output. They really contain variations of /* istanbul ignore next -- @preserve */ . snapshot: |
palisadoes
merged commit eceaad9
into
PalisadoesFoundation:develop-postgres
Issue Number:
Fixes #3217
Description:
What Changed:
The regular expression in the code_coverage_disable_check.py script has been updated to ensure that all variants of the /* istanbul ignore / comment are detected. This includes:
/ istanbul ignore /
/ istanbul ignore next /
/ istanbul ignore line /
/ istanbul ignore next -- https://github.com/preserve */
Snapshots/Videos: dummy test files to check that its working or not
If relevant, did you update the documentation?
N/A
Does this PR introduce a breaking change?
No
Other information
N/A
Summary by CodeRabbit