Refactor: jest to vitest of itemModal : fixes #2557

[bandhan-majumder]

What kind of change does this PR introduce?

Refactoring

Issue Number:

There are multiple test files in this directory. So it needs multiple PRs to close the issue. This PR fixes one such file inside that directory itemModal.spec.tsx

Fixes #2557

Snapshots/Videos:

Summary

Refactored the itemModal.tsx tests from jest to vitest in itemModal.spec.tsx

Have you read the contributing guide?

Yes

Summary by CodeRabbit

• Tests
  • Updated testing framework from Jest to Vitest for the ItemModal component tests.
  • Adjusted mocking methods for react-toastify to use vi.fn() instead of jest.fn().

[coderabbitai]

Walkthrough

This pull request focuses on refactoring the test file ItemModal.spec.tsx from using Jest to Vitest. The changes involve replacing Jest-specific mocking functions with Vitest equivalents, specifically updating jest.mock(), jest.fn(), and related mocking methods to their Vitest counterparts. The core functionality and test structure remain unchanged, ensuring that the tests for the ItemModal component continue to validate its behavior effectively.

Changes

File	Change Summary
src/screens/OrganizationActionItems/ItemModal.spec.tsx	Replaced Jest mocking methods (jest.mock(), jest.fn()) with Vitest equivalents (vi.mock(), vi.fn()) for react-toastify and component test properties

Assessment against linked issues

Objective	Addressed	Explanation
Replace Jest-specific functions and mocks with Vitest equivalents [#2557]	✅
Ensure all tests pass using npm run test:vitest [#2557]	❓	Requires full test suite verification
Maintain 100% test coverage [#2557]	❓	Requires coverage report confirmation

Possibly related issues

• Refactor : src/components/AgendaItems/AgendaItemsUpdateModal.test.tsx from Jest to Vitest #2491: Similar Vitest migration for AgendaItemsUpdateModal.test.tsx
• Refactor : src/components/AgendaItems/AgendaItemsPreviewModal.test.tsx from Jest to Vitest #2490: Similar Vitest migration for AgendaItemsPreviewModal.test.tsx
• Refactor : src/components/AgendaItems/AgendaItemsCreateModal.test.tsx from Jest to Vitest #2489: Similar Vitest migration for AgendaItemsCreateModal.test.tsx

Possibly related PRs

• Refactored src/components/AddOn/support/components/Action/Action.test.tsx from Jest to Vitest #2482: Refactoring tests from Jest to Vitest
• Refactor: src/screens/UserPortal/Volunteer/Actions from Jest to Vitest #2619: Transitioning tests to Vitest
• Refactor: src/screens/UserPortal/Volunteer/UpcomingEvents from Jest to Vitest #2623: Updating mocks for react-toastify

Suggested labels

refactor

Suggested reviewers

• palisadoes

Poem

🐰 In the realm of tests, a change takes flight,
Jest to Vitest, a migration so bright.
Mocks transformed with a gentle touch,
Code evolves, we learn so much!
Refactoring dance, a developer's delight! 🧪

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a16e02e and c50b08c.

📒 Files selected for processing (1)

• src/screens/OrganizationActionItems/ItemModal.spec.tsx (5 hunks)

🧰 Additional context used

📓 Learnings (2)

📓 Common learnings

Learnt from: bitbard3
PR: PalisadoesFoundation/talawa-admin#2588
File: src/components/ChangeLanguageDropdown/ChangeLanguageDropdown.spec.tsx:145-155
Timestamp: 2024-12-02T04:20:11.745Z
Learning: In PRs focused solely on refactoring test cases from Jest to Vitest, avoid suggesting optimizations or changes outside the migration scope.

src/screens/OrganizationActionItems/ItemModal.spec.tsx (1)

Learnt from: Chaitanya1672
PR: PalisadoesFoundation/talawa-admin#2049
File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138
Timestamp: 2024-11-12T10:40:58.654Z
Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.

🔇 Additional comments (2)

src/screens/OrganizationActionItems/ItemModal.spec.tsx (2)

24-30: LGTM! Correct migration of mock setup

The Jest to Vitest migration for the mock setup is implemented correctly:

• Proper import of vi from Vitest
• Correct replacement of jest.mock with vi.mock
• Appropriate conversion of mock functions from jest.fn() to vi.fn()

---

49-52: LGTM! Consistent migration of mock functions in props

The Jest to Vitest migration for mock functions in props is implemented correctly and consistently across all test cases:

• All instances of jest.fn() are properly replaced with vi.fn()
• The changes maintain the same functionality while using Vitest's API

Also applies to: 58-61, 67-70, 110-113, 153-156, 206-209

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

1. We don't merge PRs with poor code quality.
   1. Follow coding best practices such that CodeRabbit.ai approves your PR.
2. We don't merge PRs with failed tests.
   1. When tests fail, click on the Details link to learn more.
   2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
   3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

1. comments in this PR or
2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

1. arbitrators of future discussions with other contributors about the validity of your changes
2. point of contact for evaluating the validity of your work
3. person who verifies matching issues by others that should be closed.
4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

1. PRs with issues not assigned to you will be closed by the reviewer
2. Fix the first comment in the PR so that each issue listed automatically closes

Other

1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
2. Read the CONTRIBUTING.md file make

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (b1f4903) to head (c50b08c).
Report is 9 commits behind head on develop-postgres.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           develop-postgres    #2715      +/-   ##
====================================================
+ Coverage             86.10%   86.30%   +0.20%     
====================================================
  Files                   295      312      +17     
  Lines                  7259     8134     +875     
  Branches               1591     1785     +194     
====================================================
+ Hits                   6250     7020     +770     
- Misses                  781      937     +156     
+ Partials                228      177      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.