-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored src/utils/convertToBase64.test.ts from Jest to Vitest #2784
Conversation
WalkthroughThis pull request refactors the test suite for the Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (2)src/utils/convertToBase64.spec.ts (2)Line range hint Mocking the global
Calling Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2784 +/- ##
===========================================
- Coverage 90.52% 85.08% -5.44%
===========================================
Files 295 312 +17
Lines 7249 8132 +883
Branches 1591 1841 +250
===========================================
+ Hits 6562 6919 +357
- Misses 455 1056 +601
+ Partials 232 157 -75 ☔ View full report in Codecov by Sentry. |
This PR has to be closed. In my previous 2 messages I mentioned that we are accepting PRs only to the Please submit your PRs against our Also if applicable, make sure your branch name is different from Closing. |
My bad I didn't happen to see the comments... I was looking for the GitHub Actions what went wrong.... let me just rectify the points mentioned |
What kind of change does this PR introduce?
Refactoring
Issue Number:
Fixes #2759
Did you add tests for your changes?
No
Snapshots/Videos:
Modified the file and ran the
npm run test:vitest
command to check and it was cleared:Also ran the specific file vitest
npx vitest run .\src\utils\convertToBase64.spec.ts
:And ensured the linting and formatting:
If relevant, did you update the documentation?
Not yet
Summary
Does this PR introduce a breaking change?
No... it simply converts one test suite framework to other.
Other information
Have checked all the points in the Acceptance Criteria that was asked in the Issue:
Have you read the contributing guide?
Yes
Summary by CodeRabbit
convertToBase64
function.FileReader
functionality.