-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Organization Not Found in Left Drawer #1592
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
@GlenDsza Please fix the failing test application check. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1592 +/- ##
===========================================
+ Coverage 97.61% 97.64% +0.02%
===========================================
Files 157 157
Lines 3991 3954 -37
Branches 1201 1189 -12
===========================================
- Hits 3896 3861 -35
Misses 89 89
+ Partials 6 4 -2 ☔ View full report in Codecov by Sentry. |
Please increase the code coverage of your patch so that the tests pass |
NOTE Read very carefully
This will put your PR at risk of extensive merge conflicts. Do the following IN THIS ORDER:
This will help to reduce the number of future merge conflicts for your PR. |
Hello @Cioppolo14 , PR is ready for review. |
I had a suggestion,
Actually I have worked already on this thing, if y'all agree should I Add the changes to this PR only or should create new issue and then create PR for it |
@palisadoes need reviews/reviewers for the suggestion and PR, so could then contribute to other issues
|
Please fix the conflicting files |
@rishav-jha-mech @beingnoble03 Have resolved conflicts, added tests and addressed comments, need review |
@GlenDsza please can you update your branch with the latest changes. |
@Olatade Updated with latest changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work. lgtm.
@palisadoes not sure about the readme changes tho.
Your PR has too many unnecessary files that don’t relate to your issue. REDAME.md You can from the PR by running the commands below from the root directory of the repository git add -u |
@palisadoes @beingnoble03 Reverted changes made to |
What kind of change does this PR introduce?
bugfix
Issue Number:
Fixes #1333
Did you add tests for your changes?
Yes
Snapshots/Videos:
Fixes.No.Org.in.Left.Drawer.mp4
Summary
After Login, Opening User profile generated no organization found error, and user profile opened through 'My Organizations' page used to render '
LeftDrawerOrg
' which is meant to be rendered if user profile is opened from 'organization dashboard'.The issue is fixed by conditionally rendering
LeftDrawerOrg
Component if UserProfile is reached from organization dashboard and renderingLeftDrawer
Component if UserProfile reached from 'My Organizations Page'Added basic CSS to highlight User Profile Option in Left Drawer if User Profile Page is open.
Refactored (Simplified/Efficient)
OrganizationScreen
&SuperAdminScreen
and their respective tests.Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes