-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tests for OrganizationDashboard.tsx #1577
Create tests for OrganizationDashboard.tsx #1577
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1577 +/- ##
========================================
Coverage 96.65% 96.65%
========================================
Files 136 136
Lines 3587 3587
Branches 1101 1101
========================================
Hits 3467 3467
Misses 114 114
Partials 6 6 ☔ View full report in Codecov by Sentry. |
@palisadoes Please Check I create a Fresh PR for #1549 |
@Sauradip07 Why the coverage has not increased? |
@noman2002
|
@Sauradip07 have you tried using jest preview and checked the code coverage from the html file that gets updated everytime you make a change to your tests ? |
@rishav-jha-mech |
NOTE Read very carefully
This will put your PR at risk of extensive merge conflicts. Do the following IN THIS ORDER:
This will help to reduce the number of existing and future merge conflicts for your PR. |
@Sauradip07 for some reason, the code under the if condition is not getting executed, you need to check if the mocks are correct or not |
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
Closing due to inactivity |
Create tests for src/screens/OrganizationDashboard/OrganizationDashboard.tsx
Issue Number:
Fixes #1132
Did you add tests for your changes?
Yes
Snapshots/Videos:
Summary
Lines 86-94 & Lines 239-241 weren't covered by the tests It seems that Upcoming Events are mainly not covered
which introduce in Last PR of this File
Other information
I try to cover the entire useEffect hook
for Line 86 to 94
The 239 to 241 is already Covered but not showed in Codecov
Have you read the contributing guide?
Yes
Please feel free to reach out if there are any modifications or any changes need to be made.