-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tests for OrganizationDashboard.tsx #1549
Create tests for OrganizationDashboard.tsx #1549
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@beingnoble03 @Kevoniat Can you review this PR? |
can you share the test coverage percentage? @Sauradip07 |
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1549 +/- ##
===========================================
+ Coverage 92.77% 96.65% +3.88%
===========================================
Files 134 136 +2
Lines 3238 3587 +349
Branches 904 1101 +197
===========================================
+ Hits 3004 3467 +463
+ Misses 225 114 -111
+ Partials 9 6 -3 ☔ View full report in Codecov by Sentry. |
src/screens/OrganizationDashboard/OrganizationDashboard.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments.
src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts
Outdated
Show resolved
Hide resolved
src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the convention.
Please fix the failing tests |
In my PR, I don't change any file of I have to just re-run the CI to check is every thing is ok or not |
This should have been fixed. Do a minor commit to trigger the workflow |
You added too many new files.
|
@palisadoes |
Create tests for src/screens/OrganizationDashboard/OrganizationDashboard.tsx
Issue Number:
Fixes #1132
Did you add tests for your changes?
Yes
Snapshots/Videos:
Summary
Lines 86-94 & Lines 239-241 weren't covered by the tests It seems that Upcoming Events are mainly not covered
which introduce in Last PR of this File
Other information
I try to cover the entire useEffect hook
for Line 86 to 94
The 239 to 241 is already Covered but not showed in Codecov
Have you read the contributing guide?
Yes
Please feel free to reach out if there are any modifications or any changes need to be made.