-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react-router-dom and setup layout in routes #1495
Upgrade react-router-dom and setup layout in routes #1495
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@nitishkumar333 Please fix the PR Workflow linting related tests errors. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1495 +/- ##
===========================================
+ Coverage 96.23% 96.69% +0.45%
===========================================
Files 133 133
Lines 3404 3420 +16
Branches 1031 1039 +8
===========================================
+ Hits 3276 3307 +31
+ Misses 123 110 -13
+ Partials 5 3 -2 ☔ View full report in Codecov by Sentry. |
@nitishkumar333 Please fix the codecov failing tests. |
The only file which is giving codecov error now is AddOnStore, I can't write tests for it because most part of the file is commented ( I think someone is working on it ). It will be a different issue to cover that file. All of my changes have 100% coverage, as a result code coverage is up by +0.45% Please review the PR. |
@beingnoble03 @Kevoniat Can you review this PR? |
@nitishkumar333 Please fix the conflicting files. |
Please fix the failing tests
|
@palisadoes all the files changes by me have 100% coverage and code coverage is increased by +0.45% from this PR. The only file which is giving codecov error now is AddOnStore, I can't write tests for it because most part of the file is commented ( I think someone is working on it ). It will be a different issue to cover that file. |
|
Closing due to inactivity. |
Hi @noman2002, sorry for the delay was having my exams, please reopen this PR i would like to complete it. |
What kind of change does this PR introduce?
Refactoring
Fixes #1407
Did you add tests for your changes?
Yes
Snapshots/Videos:
router.mp4
Summary
Upgraded react-router-dom to latest version and refactored the code by setting up layout for routes in App.tsx.