Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-router-dom and setup layout in routes #1495

Conversation

nitishkumar333
Copy link
Contributor

What kind of change does this PR introduce?
Refactoring

Fixes #1407

Did you add tests for your changes?
Yes

Snapshots/Videos:

router.mp4

Summary
Upgraded react-router-dom to latest version and refactored the code by setting up layout for routes in App.tsx.

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@Cioppolo14
Copy link
Contributor

@nitishkumar333 Please fix the PR Workflow linting related tests errors.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (751bcbe) 96.23% compared to head (26d46af) 96.69%.
Report is 9 commits behind head on develop.

Files Patch % Lines
...rc/components/AddOn/core/AddOnStore/AddOnStore.tsx 3.33% 29 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1495      +/-   ##
===========================================
+ Coverage    96.23%   96.69%   +0.45%     
===========================================
  Files          133      133              
  Lines         3404     3420      +16     
  Branches      1031     1039       +8     
===========================================
+ Hits          3276     3307      +31     
+ Misses         123      110      -13     
+ Partials         5        3       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cioppolo14
Copy link
Contributor

@nitishkumar333 Please fix the codecov failing tests.

@nitishkumar333
Copy link
Contributor Author

@Cioppolo14

The only file which is giving codecov error now is AddOnStore, I can't write tests for it because most part of the file is commented ( I think someone is working on it ). It will be a different issue to cover that file.

All of my changes have 100% coverage, as a result code coverage is up by +0.45%

Please review the PR.

@Cioppolo14
Copy link
Contributor

@beingnoble03 @Kevoniat Can you review this PR?

@Cioppolo14
Copy link
Contributor

@nitishkumar333 Please fix the conflicting files.

@palisadoes
Copy link
Contributor

Please fix the failing tests

  • Code coverage is declining. The tests for the files you have submitted are not complete

@nitishkumar333
Copy link
Contributor Author

@palisadoes all the files changes by me have 100% coverage and code coverage is increased by +0.45% from this PR.

The only file which is giving codecov error now is AddOnStore, I can't write tests for it because most part of the file is commented ( I think someone is working on it ). It will be a different issue to cover that file.

@palisadoes
Copy link
Contributor

palisadoes commented Jan 30, 2024

  1. Please fix the failing introspection test
    1. The API was recently updated and you'll need to update your code to match
  2. Let us know when the PR is ready for review

@noman2002
Copy link
Member

Closing due to inactivity.

@noman2002 noman2002 closed this Feb 11, 2024
@nitishkumar333
Copy link
Contributor Author

Hi @noman2002, sorry for the delay was having my exams, please reopen this PR i would like to complete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants