-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade React-router-dom to latest version and setup layouts #1407
Comments
Please assign it to me if its needed. |
@noman2002 @palisadoes Should this be done outside of #1413? They seem to overlap. @nitishkumar333 I apologize I want to get more feedback before assigning. |
Hi, Can I work on this issue |
@rishav-jha-mech @EshaanAgg @aashimawadhwa What are your thoughts on this and its relevance to #1413 ? |
Per a discussion with @aashimawadhwa, this needs to be addressed. I am assigning @nitishkumar333. Please let me know if you no longer want this issue. |
@Cioppolo14 Thank you, Working on it. |
Update - improved the performance by updating routing structure, working on failing tests, will soon make the PR update.mp4 |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Hi, Can I work on this issue |
@Cioppolo14 please reassign me this issue and reopen the pr, I have already made a PR for this issue ( #1495 ) sorry for the delay I was inactive for some days due to exams. |
@nitishkumar333 I'm sorry that the timing didn't work out. We'd like to give someone else a chance to solve this one. There should be other issues you can work on. Thank you for your time. |
Thankyou for assigning this issue to me, will submit pr as soon as possible |
While ugrading react router dom i facing difficulties coz many packages have been deprecated, so should i work on that or leave them. |
|
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Unassigning. No activity |
Can I work on it again, if no one is working on this ? |
Sorry, I was going to submit pr today only |
Is your feature request related to a problem? Please describe.
We are rendering the LeftDrawer (sidebar) component on every endpoint, which is a major performance issue, sidebar should be made common is all endpoints.
Newer version of react-router-dom allows us to setup layouts for common component to improve performance.
Currently Talawa-admin uses react-router-dom v5.2.0 which was released in 2020.
They have introduced many changes since then like,
useHistory hook is changed to useNavigate
Switch is changed to Routes
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359
The text was updated successfully, but these errors were encountered: