Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React-router-dom to latest version and setup layouts #1407

Closed
nitishkumar333 opened this issue Jan 8, 2024 · 18 comments
Closed

Upgrade React-router-dom to latest version and setup layouts #1407

nitishkumar333 opened this issue Jan 8, 2024 · 18 comments
Assignees

Comments

@nitishkumar333
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We are rendering the LeftDrawer (sidebar) component on every endpoint, which is a major performance issue, sidebar should be made common is all endpoints.

Newer version of react-router-dom allows us to setup layouts for common component to improve performance.

Currently Talawa-admin uses react-router-dom v5.2.0 which was released in 2020.
They have introduced many changes since then like,
useHistory hook is changed to useNavigate
Switch is changed to Routes

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@nitishkumar333
Copy link
Contributor Author

Please assign it to me if its needed.

@Cioppolo14
Copy link
Contributor

@noman2002 @palisadoes Should this be done outside of #1413? They seem to overlap.

@nitishkumar333 I apologize I want to get more feedback before assigning.

@dhruvgupta0503
Copy link

Hi, Can I work on this issue

@palisadoes
Copy link
Contributor

@rishav-jha-mech @EshaanAgg @aashimawadhwa What are your thoughts on this and its relevance to #1413 ?

@Cioppolo14
Copy link
Contributor

Per a discussion with @aashimawadhwa, this needs to be addressed. I am assigning @nitishkumar333. Please let me know if you no longer want this issue.

@nitishkumar333
Copy link
Contributor Author

@Cioppolo14 Thank you, Working on it.

@nitishkumar333
Copy link
Contributor Author

Update - improved the performance by updating routing structure, working on failing tests, will soon make the PR

update.mp4

Copy link

github-actions bot commented Feb 1, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 1, 2024
@github-actions github-actions bot removed the no-issue-activity No issue activity label Feb 12, 2024
@dhruvgupta0503
Copy link

Hi, Can I work on this issue

@nitishkumar333
Copy link
Contributor Author

@Cioppolo14 please reassign me this issue and reopen the pr, I have already made a PR for this issue ( #1495 ) sorry for the delay I was inactive for some days due to exams.

@Cioppolo14
Copy link
Contributor

@nitishkumar333 I'm sorry that the timing didn't work out. We'd like to give someone else a chance to solve this one. There should be other issues you can work on. Thank you for your time.

@dhruvgupta0503
Copy link

Thankyou for assigning this issue to me, will submit pr as soon as possible

@dhruvgupta0503
Copy link

While ugrading react router dom i facing difficulties coz many packages have been deprecated, so should i work on that or leave them.

@palisadoes
Copy link
Contributor

  1. Please upgrade the packages.
  2. Limit the changes to the package.json file only. Hopefully this will be sufficient
  3. We have had bad experiences in the past when people updated package-lock.json, do not edit that file.

Copy link

github-actions bot commented Mar 1, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 1, 2024
@palisadoes
Copy link
Contributor

Unassigning. No activity

@nitishkumar333
Copy link
Contributor Author

Can I work on it again, if no one is working on this ?

@dhruvgupta0503
Copy link

Sorry, I was going to submit pr today only
got some issues while submitting pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants