Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr workflow updated for changed files #1207

Closed
wants to merge 8 commits into from
Closed
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions .github/workflows/pull-requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,20 @@
##############################################################################

name: PR Workflow

on:
pull_request:
branches:
- '**'

env:
CODECOV_UNIQUE_NAME: CODECOV_UNIQUE_NAME-${{ github.run_id }}-${{ github.run_number }}
CODECOV_UNIQUE_NAME: CODECOV_UNIQUE_NAME-${{ github.run_id }}-${{ github.run_number }}

jobs:

Continuous-Integration:

name: Performs linting, formatting, type-checking and testing on the application
name: Performs linting, formatting, type-checking, and testing on the application
runs-on: ubuntu-latest
steps:
- name: Checkout the Repository
Expand All @@ -33,7 +34,7 @@ jobs:

- name: Run linting check
run: npm run lint:check

- name: Count number of lines
run: |
chmod +x ./.github/workflows/countline.py
Expand All @@ -44,34 +45,47 @@ jobs:

- name: Check for type errors
run: npm run typecheck

- name: Run tests
run: npm run test -- --watchAll=false --coverage


- name: Get changed TypeScript files
id: changed-files
uses: actions/changed-files@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be using a different version of the action. Check the GitHub action's website. They are not using V1 anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the changed file issue also added checked file condition


- name: TypeScript compilation for changed files
run: |
for file in ${{ steps.changed-files.outputs.all_files }}; do
if [[ "$file" == *.ts || "$file" == *.tsx ]]; then
npx tsc --noEmit "$file"
fi
done

- name: Present and Upload coverage to Codecov as ${{env.CODECOV_UNIQUE_NAME}}
uses: codecov/codecov-action@v3
with:
verbose: true
fail_ci_if_error: false
name: '${{env.CODECOV_UNIQUE_NAME}}'
name: '${{env.CODECOV_UNIQUE_NAME}}'

- name: Test acceptable level of code coverage
uses: VeryGoodOpenSource/very_good_coverage@v2
with:
path: "./coverage/lcov.info"
min_coverage: 95.0

Graphql-Inspector:
name: Runs Introspection on the github talawa-api repo on the schema.graphql file
name: Runs Introspection on the GitHub talawa-api repo on the schema.graphql file
runs-on: ubuntu-latest
steps:
- name: Checkout the Repository
uses: actions/checkout@v3

- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: '16.14.1'

- name: resolve dependency
run: npm install -g @graphql-inspector/cli

Expand Down
Loading