-
-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr workflow updated for changed files #1207
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Include the eslint configuration file with the desired changes.
- How do you plan to get whether this works? I don't want to have the same problems repeated. As you and @tasneemkoushar are in the same timezone I'd suggest that you work together on a Zoom call to make sure subsequent PRs work as expected. For example using test PRs immediately after merging.
.github/workflows/pull-requests.yml
Outdated
|
||
- name: Get changed TypeScript files | ||
id: changed-files | ||
uses: actions/changed-files@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be using a different version of the action. Check the GitHub action's website. They are not using V1 anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed the changed file issue also added checked file condition
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 134 134
Lines 3238 3238
Branches 904 904
=======================================
Hits 3004 3004
Misses 225 225
Partials 9 9 ☔ View full report in Codecov by Sentry. |
@palisadoes |
@anwersayeed please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
|
What kind of change does this PR introduce?
Issue Number:
Fixes #1117
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?