Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr workflow updated for changed files #1207

Closed
wants to merge 8 commits into from

Conversation

duplixx
Copy link
Member

@duplixx duplixx commented Dec 16, 2023

What kind of change does this PR introduce?

Issue Number:

Fixes #1117

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

@duplixx duplixx requested a review from palisadoes as a code owner December 16, 2023 09:30
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Include the eslint configuration file with the desired changes.
  2. How do you plan to get whether this works? I don't want to have the same problems repeated. As you and @tasneemkoushar are in the same timezone I'd suggest that you work together on a Zoom call to make sure subsequent PRs work as expected. For example using test PRs immediately after merging.


- name: Get changed TypeScript files
id: changed-files
uses: actions/changed-files@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be using a different version of the action. Check the GitHub action's website. They are not using V1 anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the changed file issue also added checked file condition

@palisadoes
Copy link
Contributor

@duplixx

  1. Is this ready for review?
  2. Is the failed test part of the testing of this PR? If so, please restore the files correctly.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ff2924) 92.77% compared to head (92c7753) 92.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1207   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         134      134           
  Lines        3238     3238           
  Branches      904      904           
=======================================
  Hits         3004     3004           
  Misses        225      225           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duplixx
Copy link
Member Author

duplixx commented Dec 21, 2023

@palisadoes
yeah I have fixed the failing test,and the PR is ready to be reviewed
Thanks!!

@palisadoes
Copy link
Contributor

@anwersayeed please take a look

Copy link
Contributor

@anwersayeed anwersayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@palisadoes
Copy link
Contributor

@duplixx

  1. This needs to be merged against develop
  2. Please resubmit
  3. Closing

@palisadoes palisadoes closed this Dec 21, 2023
@duplixx duplixx deleted the PR-WORKFLOW branch December 21, 2023 20:55
@duplixx duplixx restored the PR-WORKFLOW branch December 21, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR Workflow Enhancement - Delta Error/Warning Checks
3 participants