Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[userTypeFix] Removal of adminApproved field #1845

Closed
pranshugupta54 opened this issue Mar 29, 2024 · 4 comments
Closed

[userTypeFix] Removal of adminApproved field #1845

pranshugupta54 opened this issue Mar 29, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@pranshugupta54
Copy link
Member

pranshugupta54 commented Mar 29, 2024

Describe the bug

  • adminApproved field is not being used anymore after the change in userType.
  • Remove all the code using it.

Actual behavior
Every feature should be working, tests and code coverage.

Screenshots
NA

Additional details

  1. We are using userRegistrationRequired bool for checking approval in Org.
  2. membershipRequests array for list of pending users in Org.
  3. adminApproved was earlier used for orgs but it's global.
  4. All tests must pass and be valid
  5. No other functionality must be affected

References:

  1. [userTypeFix] Removal of adminApproved field talawa-api#2122
  2. https://thepalisadoes-dyb6419.slack.com/archives/C01RPC00K0D/p1711717178931399

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@pranshugupta54 pranshugupta54 added the bug Something isn't working label Mar 29, 2024
@palisadoes palisadoes changed the title Removal of adminApproved field [userTypeFix] Removal of adminApproved field Mar 29, 2024
@disha1202
Copy link
Contributor

I would like to work on this

@disha1202
Copy link
Contributor

Also, are we sure this needs to be removed.

If in future we're planning to add the newMemberApprovalsRequired flag for approvals to join a community (i.e. not being able to access the user the admin portal unless approved by an admin or super admin).

Then we'll need a field i.e. adminApproved to track whether the user is approved or not. This field can be set to true in the default case.

we'll have to implement it again.

@palisadoes
Copy link
Contributor

We already have the userRegistrationRequired flag as discussed in the slack conversation.

@disha1202
Copy link
Contributor

We already have the userRegistrationRequired flag as discussed in the slack conversation.

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants