-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed adminApproved field #1866
removed adminApproved field #1866
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@disha1202 remove the |
Sure, I'll remove them. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1866 +/- ##
===========================================
- Coverage 98.26% 98.26% -0.01%
===========================================
Files 198 198
Lines 5079 5077 -2
Branches 1491 1487 -4
===========================================
- Hits 4991 4989 -2
Misses 83 83
Partials 5 5 ☔ View full report in Codecov by Sentry. |
This PR is ready for review. |
70642ec
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
refactoring
Issue Number:
Fixes #1845
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?