Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove adminApproved field and its usage #2150

Merged

Conversation

meetulr
Copy link
Contributor

@meetulr meetulr commented Apr 3, 2024

What kind of change does this PR introduce?

It removes the uses and references of the adminApproved field.

Issue Number:

Fixes #2122

If relevant, did you update the documentation?

Yes

Copy link

github-actions bot commented Apr 3, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@Olatade
Copy link

Olatade commented Apr 3, 2024

@meetulr please fix failing tests

@meetulr
Copy link
Contributor Author

meetulr commented Apr 3, 2024

@meetulr please fix failing tests

The test is failing because of a recent eslint upgrade. There's an issue open to address this: #2146. I'll merge with upstream as soon as it's resolved.

@palisadoes
Copy link
Contributor

Please update with the latest upstream. It's Fixed.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.74%. Comparing base (0987209) to head (65d79c4).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2150      +/-   ##
===========================================
- Coverage    96.77%   96.74%   -0.03%     
===========================================
  Files          342      340       -2     
  Lines        23115    22943     -172     
  Branches      2041     2027      -14     
===========================================
- Hits         22369    22197     -172     
  Misses         741      741              
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meetulr
Copy link
Contributor Author

meetulr commented Apr 4, 2024

This is ready.

@palisadoes palisadoes merged commit c40215c into PalisadoesFoundation:develop Apr 4, 2024
9 of 11 checks passed
@meetulr meetulr deleted the remove-adminApproved branch April 5, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants