-
-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove adminApproved
field and its usage
#2150
fix: remove adminApproved
field and its usage
#2150
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@meetulr please fix failing tests |
Please update with the latest upstream. It's Fixed. |
…awa-api into remove-adminApproved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2150 +/- ##
===========================================
- Coverage 96.77% 96.74% -0.03%
===========================================
Files 342 340 -2
Lines 23115 22943 -172
Branches 2041 2027 -14
===========================================
- Hits 22369 22197 -172
Misses 741 741
Partials 5 5 ☔ View full report in Codecov by Sentry. |
This is ready. |
c40215c
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
It removes the uses and references of the
adminApproved
field.Issue Number:
Fixes #2122
If relevant, did you update the documentation?
Yes