Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-router-dom and setup layout in routes #1666

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

nitishkumar333
Copy link
Contributor

What kind of change does this PR introduce?
Feature

Issue Number:
Fixes #1407

Did you add tests for your changes?
Yes

video-router.mp4

Summary
Upgraded react-router-dom to latest version and refactored the code by setting up layout for routes in App.tsx.

Have you read the contributing guide?
Yes

Copy link

github-actions bot commented Mar 4, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 98.56459% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 97.53%. Comparing base (655b6b3) to head (1504620).
Report is 221 commits behind head on develop.

❗ Current head 1504620 differs from pull request most recent head 29d70ce. Consider uploading reports for the commit 29d70ce to get more accurate results

Files Patch % Lines
.../screens/OrganizationPeople/OrganizationPeople.tsx 76.47% 4 Missing ⚠️
...ns/OrganizationDashboard/OrganizationDashboard.tsx 98.18% 1 Missing ⚠️
src/screens/UserPortal/Home/Home.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1666      +/-   ##
===========================================
+ Coverage    92.77%   97.53%   +4.76%     
===========================================
  Files          134      157      +23     
  Lines         3238     3895     +657     
  Branches       904     1148     +244     
===========================================
+ Hits          3004     3799     +795     
+ Misses         225       92     -133     
+ Partials         9        4       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashimawadhwa
Copy link
Member

Can you merge the latest changes from develop so we can review it further? @nitishkumar333

@nitishkumar333
Copy link
Contributor Author

Please approve the Workflow request

@nitishkumar333
Copy link
Contributor Author

This PR is ready for review. I request to review this PR before any other to avoid extensive merge conflicts as there are 88 files changed in this.

@palisadoes palisadoes merged commit 308a00c into PalisadoesFoundation:develop Mar 5, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants