-
-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react-router-dom and setup layout in routes #1666
Upgrade react-router-dom and setup layout in routes #1666
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1666 +/- ##
===========================================
+ Coverage 92.77% 97.53% +4.76%
===========================================
Files 134 157 +23
Lines 3238 3895 +657
Branches 904 1148 +244
===========================================
+ Hits 3004 3799 +795
+ Misses 225 92 -133
+ Partials 9 4 -5 ☔ View full report in Codecov by Sentry. |
Can you merge the latest changes from develop so we can review it further? @nitishkumar333 |
Please approve the Workflow request |
This PR is ready for review. I request to review this PR before any other to avoid extensive merge conflicts as there are 88 files changed in this. |
308a00c
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Feature
Issue Number:
Fixes #1407
Did you add tests for your changes?
Yes
video-router.mp4
Summary
Upgraded react-router-dom to latest version and refactored the code by setting up layout for routes in App.tsx.
Have you read the contributing guide?
Yes