-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projected NFT funnel #259
Merged
+2,362
−1,095
Merged
Projected NFT funnel #259
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
09ece57
add carp funnel with stake delegation pool tracking
ecioppettini f30d983
use local (tmp) carp client lib in the funnel
ecioppettini a8f417c
replace carp local client with 2.3.0 from npm
ecioppettini 91ba6a5
handle presync in carp funnel
ecioppettini 3788338
use local (tmp) carp client lib in the funnel
ecioppettini 96d9449
add stopSlot setting to stop fetching
ecioppettini db32958
address review comments
ecioppettini acb7964
Initial setups
gostkin abd7a38
Queries & rebase
gostkin 8972ee0
Funnel fixes
gostkin 73d76e0
Lint & minor fixes
gostkin 0248309
More lint fixes
gostkin 1befbef
Remove checks for owner address
gostkin c00f752
Address review comments
gostkin 97e3cd5
Minor fixes
gostkin cf5a740
number -> bigint for asset amount
gostkin 13f4962
bigint -> string
gostkin c63fe7c
Update carp client and fix issue with big numbers in projected NFT
gostkin 627d81c
Fix lint
gostkin 965c624
Asset -> policy id + asset name
gostkin 38e41d8
Update carp client call
gostkin 7197527
Fix paima tables
gostkin f0b3492
Remove tsoa routes
gostkin d6dbcff
Address review comments
gostkin 1dc2c32
Merge pull request #274 from PaimaStudios/egostkin/projected-nft-spli…
gostkin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,4 +9,6 @@ bin | |
| # logs | ||
| *.log | ||
|
|
||
| .idea/ | ||
| .idea/ | ||
|
|
||
| packages/engine/paima-rest/src/tsoa/routes.ts | ||
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't add this to gitingore I think because it will break some other systems that require parsing this file. The real solution would be trying to find out why this file sometimes gets formatted by a tool (possibly prettier) despite being specified in the
.prettierignore. Runningprettieron the git repo as expected ignores this file, but it's possiblenxor some other tool is not respecting this somewhereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but how git relates to these systems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's just a file that is not tracked by the repo if it is ignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would it break anything? otherwise one should always specify all subfolders or do
git rmon this file which is not very convenient. if we don't need a file in a repo it's better to ignore it imo if it doesn't break thingsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many systems and tools look at git for their behavior. Please let's not waste time arguing about this and just do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed on the call i added back this file since it was not tracked by git and removed it from gitignore