Projected NFT funnel #259

gostkin · 2023-11-28T18:40:52Z

Projected NFT Funnel

Setup

Add extensions.yml to folder where the game binary is located:

extensions:
  - name: "Cardano Projected NFT"
    type: cardano-projected-nft
    contract: "703ec99926211daafe291951b778d4da7736a8b0da2aeb92305b511a72"
    startSlot: 43201686
    scheduledPrefix: cpnft

Add vars to .env:

CARP_URL=http://localhost:3000
CARDANO_NETWORK=preprod
CARDANO_CONFIRMATION_DEPTH=10

packages/engine/paima-funnel/src/cde/cardanoProjectedNFT.ts

packages/engine/paima-runtime/src/cde-config/utils.ts

just to test until the up to date version is published on npm

packages/engine/paima-sm/src/types.ts

SebastienGllmt · 2023-12-13T04:03:33Z

packages/engine/paima-funnel/src/cde/cardanoProjectedNFT.ts

+    payload: {
+      ownerAddress: event.ownerAddress != null ? event.ownerAddress : '',
+
+      actionTxId: event.actionTxId,


Note that games only care about NFTs getting locked and queued to unlock. We don't care if the user ever actually ends up withdrawing their NFT from the lock later.

packages/engine/paima-sm/src/types.ts

packages/node-sdk/paima-utils-backend/src/cde-access.ts

SebastienGllmt · 2023-12-13T04:24:55Z

packages/engine/paima-sm/src/types.ts

+export const ChainDataExtensionCardanoProjectedNFTConfig = Type.Object({
+  type: Type.Literal(CdeEntryTypeName.CardanoProjectedNFT),
+  contract: Type.String(),
+  scheduledPrefix: Type.String(),


Probably this should be optional since most games will probably not need to update their state machine based on somebody locking or queuing to unlock

Probably what is more important is the getCardanoAddressProjectedNfts function you wrote

I probably don't fully understand the role of scheduledPrefix, could you explain pls?

scheduledPrefix is the event that get scheduled to be sent over to the state machine for the game

For example, you can see entrypoint for the state machine of a game here use a switch-case on the prefix of the message it receives from Paima.

SebastienGllmt · 2023-12-13T04:27:14Z

packages/engine/paima-sm/src/types.ts

+  scheduledPrefix: Type.String(),
+  startSlot: Type.Number(),
+  stopSlot: Type.Optional(Type.Number()),
+  name: Type.String(),


I wonder if we should allow specifying a list of NFT collections you want to filter too. It seems like maybe over-optimizing, but it may cut down on the size of the Carp requests so it may actually make a difference (since if many contracts are using projected NFTs, filtering Carp queries for a specific set of collections may reduce the number of times you have to paginate)

Not a high priority for v1 I guess

we can do it easily, but i'd change asset to policy id and asset name for better search options

dcSpark/carp#167

SebastienGllmt · 2023-12-18T17:31:56Z

packages/engine/paima-rest/src/tsoa/routes.ts

@@ -0,0 +1,347 @@
+/* tslint:disable */


don't commit this file

let's add it to gitignore then

SebastienGllmt · 2023-12-18T17:35:19Z

packages/engine/paima-funnel/src/cde/cardanoProjectedNFT.ts

+    query(url, Routes.projectedNftEventsRange, {
+      range: { minSlot: fromAbsoluteSlot, maxSlot: toAbsoluteSlot },
+    }),


Will this handle pagination properly?

yes, as long as the range is not too big it will work fine

and the request is not split to pages

SebastienGllmt · 2023-12-19T05:23:42Z

.gitignore

+.idea/
+
+packages/engine/paima-rest/src/tsoa/routes.ts


We can't add this to gitingore I think because it will break some other systems that require parsing this file. The real solution would be trying to find out why this file sometimes gets formatted by a tool (possibly prettier) despite being specified in the .prettierignore. Running prettier on the git repo as expected ignores this file, but it's possible nx or some other tool is not respecting this somewhere

but how git relates to these systems?

it's just a file that is not tracked by the repo if it is ignored

why would it break anything? otherwise one should always specify all subfolders or do git rm on this file which is not very convenient. if we don't need a file in a repo it's better to ignore it imo if it doesn't break things

Many systems and tools look at git for their behavior. Please let's not waste time arguing about this and just do it

as discussed on the call i added back this file since it was not tracked by git and removed it from gitignore

SebastienGllmt · 2023-12-21T07:07:24Z

We also need to update the Paima docs with information about this CDE as well

gostkin · 2023-12-21T14:01:17Z

We also need to update the Paima docs with information about this CDE as well

will add, are the docs blocking this PR to be merged?

…t-asset Make policy id and asset name separate

ecioppettini force-pushed the carp-funnel-stake-delegation-cde branch from 6080ca7 to 879218d Compare November 30, 2023 02:39

gostkin changed the title ~~Initial setups~~ Projected NFT funnel Dec 4, 2023

gostkin force-pushed the egostkin/paima-projected-nft-funnel branch 4 times, most recently from 820071e to 1b8f719 Compare December 8, 2023 12:49

gostkin marked this pull request as ready for review December 8, 2023 12:52

gostkin requested review from SebastienGllmt and ecioppettini December 8, 2023 12:52

ecioppettini reviewed Dec 12, 2023

View reviewed changes

packages/engine/paima-funnel/src/cde/cardanoProjectedNFT.ts Show resolved Hide resolved

packages/engine/paima-runtime/src/cde-config/utils.ts Outdated Show resolved Hide resolved

Base automatically changed from carp-funnel-stake-delegation-cde to master December 12, 2023 21:55

ecioppettini and others added 14 commits December 12, 2023 23:37

add carp funnel with stake delegation pool tracking

09ece57

use local (tmp) carp client lib in the funnel

f30d983

just to test until the up to date version is published on npm

replace carp local client with 2.3.0 from npm

a8f417c

handle presync in carp funnel

91ba6a5

use local (tmp) carp client lib in the funnel

3788338

just to test until the up to date version is published on npm

add stopSlot setting to stop fetching

96d9449

address review comments

db32958

Initial setups

acb7964

Queries & rebase

abd7a38

Funnel fixes

8972ee0

Lint & minor fixes

73d76e0

More lint fixes

0248309

Remove checks for owner address

1befbef

Address review comments

c00f752

gostkin force-pushed the egostkin/paima-projected-nft-funnel branch from fbb49d9 to c00f752 Compare December 12, 2023 22:56

Minor fixes

97e3cd5

gostkin force-pushed the egostkin/paima-projected-nft-funnel branch from 8ea365e to 97e3cd5 Compare December 12, 2023 23:09

gostkin requested a review from ecioppettini December 12, 2023 23:12

SebastienGllmt reviewed Dec 13, 2023

View reviewed changes

packages/engine/paima-sm/src/types.ts Outdated Show resolved Hide resolved

SebastienGllmt mentioned this pull request Dec 13, 2023

Fixes for: multiple NFTs claim and partial withdrawal connection history dcSpark/carp#164

Merged

SebastienGllmt reviewed Dec 13, 2023

View reviewed changes

packages/engine/paima-sm/src/types.ts Outdated Show resolved Hide resolved

SebastienGllmt reviewed Dec 13, 2023

View reviewed changes

packages/node-sdk/paima-utils-backend/src/cde-access.ts Outdated Show resolved Hide resolved

SebastienGllmt reviewed Dec 13, 2023

View reviewed changes

gostkin added 4 commits December 15, 2023 02:09

number -> bigint for asset amount

cf5a740

bigint -> string

13f4962

Update carp client and fix issue with big numbers in projected NFT

c63fe7c

Fix lint

627d81c

gostkin requested a review from SebastienGllmt December 18, 2023 15:53

Asset -> policy id + asset name

965c624

SebastienGllmt reviewed Dec 18, 2023

View reviewed changes

Update carp client call

38e41d8

gostkin mentioned this pull request Dec 19, 2023

Make policy id and asset name separate #274

Merged

gostkin added 2 commits December 19, 2023 02:32

Fix paima tables

7197527

Remove tsoa routes

f0b3492

gostkin requested a review from SebastienGllmt December 19, 2023 02:41

SebastienGllmt reviewed Dec 19, 2023

View reviewed changes

Address review comments

d6dbcff

gostkin requested a review from SebastienGllmt December 21, 2023 14:02

Merge pull request #274 from PaimaStudios/egostkin/projected-nft-spli…

1dc2c32

…t-asset Make policy id and asset name separate

SebastienGllmt approved these changes Dec 29, 2023

View reviewed changes

SebastienGllmt merged commit 13f2781 into master Dec 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Projected NFT funnel #259

Projected NFT funnel #259

gostkin commented Nov 28, 2023 •

edited

Loading

SebastienGllmt Dec 13, 2023

SebastienGllmt Dec 13, 2023 •

edited

Loading

gostkin Dec 15, 2023

SebastienGllmt Dec 15, 2023

SebastienGllmt Dec 13, 2023

gostkin Dec 15, 2023

gostkin Dec 18, 2023

SebastienGllmt Dec 18, 2023

gostkin Dec 18, 2023

SebastienGllmt Dec 18, 2023

gostkin Dec 18, 2023

gostkin Dec 18, 2023

SebastienGllmt Dec 19, 2023

gostkin Dec 19, 2023

gostkin Dec 19, 2023

gostkin Dec 19, 2023

SebastienGllmt Dec 21, 2023 •

edited

Loading

gostkin Dec 21, 2023

SebastienGllmt commented Dec 21, 2023

gostkin commented Dec 21, 2023

		.idea/

		packages/engine/paima-rest/src/tsoa/routes.ts

Projected NFT funnel #259

Projected NFT funnel #259

Conversation

gostkin commented Nov 28, 2023 • edited Loading

Setup

Choose a reason for hiding this comment

SebastienGllmt Dec 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SebastienGllmt Dec 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SebastienGllmt commented Dec 21, 2023

gostkin commented Dec 21, 2023

gostkin commented Nov 28, 2023 •

edited

Loading

SebastienGllmt Dec 13, 2023 •

edited

Loading

SebastienGllmt Dec 21, 2023 •

edited

Loading