Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy and paste bugs #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix copy and paste bugs #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20cb60a
fix copyandpaste lint error
alingse Jan 10, 2024
8084d53
fix copyandpaste lint error
alingse Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion chapter/16/workflow/internal/service/jobs/register/tokenbucket/tokenbucket.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@ Package tokenbucket registers a job that is used to fetch a token from a token b

Register name: "tokenBucket"
Args:

"bucket"(mandatory): The name of the bucket
"fatal"(mandatory): true if a failure should cause a fatal error, false if it should block until it gets one

Result:

If the site is not in decom, will return a fatal error.
*/
package tokenbucket
Expand Down Expand Up @@ -59,7 +62,7 @@ func (a *args) validate(args map[string]string) error {
case "true":
a.fatal = true
case "false":
a.fatal = true
a.fatal = false
default:
return fmt.Errorf("arg(fatal) was not true or false, was %q", v)
}
Expand Down
2 changes: 1 addition & 1 deletion chapter/8/rollout/lb/client/cli/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func main() {
Port: int32(*port),
URLPath: *urlPath,
}
if err := c.AddBackend(ctx, *pattern, b); err != nil {
if err := c.RemoveBackend(ctx, *pattern, b); err != nil {
panic(err)
}
case "poolHealth":
Expand Down