Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy and paste bugs #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alingse
Copy link

@alingse alingse commented Jan 10, 2024

I was write a linter https://github.com/alingse/copyandpaste that detect the same code in different branch.

this is mostly a copy and paste things.

I search and post the popular repo in the github and run the workflow.

Here is this repo's result log.

Error: /home/runner/work/copyandpaste/copyandpaste/Go-for-DevOps/chapter/16/workflow/internal/service/jobs/register/tokenbucket/tokenbucket.go:61:4: Duplicate case body found for case "false": and case "true": Is it a copy and paste?
Error: /home/runner/work/copyandpaste/copyandpaste/Go-for-DevOps/chapter/8/rollout/lb/client/cli/cli.go:[7](https://github.com/alingse/copyandpaste/actions/runs/7476736381/job/20347830235#step:7:8)0:2: Duplicate case body found for case "removeBackend": and case "addBackend": Is it a copy and paste?

from the code context. I think these two is a bug.

@alingse
Copy link
Author

alingse commented Jan 16, 2024

@devigned need help

@devigned devigned closed this Jan 16, 2024
@devigned devigned reopened this Jan 16, 2024
@devigned
Copy link
Collaborator

@johnsiilver please take a look when you have a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants