VehicleAirData: remove unused air temperature handling #23753
+0
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
_air_temperature_celsius
is not used anywhere anymore.Solution
Remove it along and all related.
Changelog Entry
For release notes:
Alternatives
Should we re-visit the temperature handling? Does it make sense to use the baro temperature for the rho calculation when we also would have the (usually) more accurate temperature from differential_pressure? How do we handle too high baro temperature readings due to board heat up (for differential pressure we constantly subtract 5 deg, see PCB_TEMP_ESTIMATE_DEG). Is there a smarter way? Should we even leave it up to user to specify source of temperature?