Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VehicleAirData: remove unused air temperature handling #23753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Oct 1, 2024

Solved Problem

_air_temperature_celsius is not used anywhere anymore.

Solution

Remove it along and all related.

Changelog Entry

For release notes:

Feature/Bugfix XYZ
New parameter: XYZ_Z
Documentation: Need to clarify page ... / done, read docs.px4.io/...

Alternatives

Should we re-visit the temperature handling? Does it make sense to use the baro temperature for the rho calculation when we also would have the (usually) more accurate temperature from differential_pressure? How do we handle too high baro temperature readings due to board heat up (for differential pressure we constantly subtract 5 deg, see PCB_TEMP_ESTIMATE_DEG). Is there a smarter way? Should we even leave it up to user to specify source of temperature?

@sfuhrer sfuhrer requested a review from haumarco October 1, 2024 07:12
@dagar
Copy link
Member

dagar commented Oct 1, 2024

I think it would be better to actually use, but maybe we could review it from the perspective of a real use case (with log)?

  • prefer external baro temperature if available
  • willing to use differential pressure sensor temperature otherwise (wait until validated?)
  • otherwise optionally consider using internal baro (probably without the hardcoded PCB_TEMP_ESTIMATE_DEG) or just use STP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants