HealthAndArmingChecks: improve messaging for position estimate failure #23711
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silvan Fuhrer <[email protected]>
MaEtUgR
reviewed
Oct 1, 2024
| */ | ||
| reporter.armingCheckFailure(local_position_modes, health_component_t::local_position_estimate, | ||
| events::ID("check_modes_local_pos"), | ||
| events::Log::Error, "No valid local position estimate"); | ||
| events::Log::Error, "Navigation error: No valid local position estimate"); |
There was a problem hiding this comment.
Could we simplify by saying local position estimate = (any) position estimate, since we never have a global estimate without a local one? 🤔
Would bring me down to "Positioning insufficient, selected mode can't navigate."
This can be adapted for "global positioning" and "altitude estimate".
There was a problem hiding this comment.
Could we simplify by saying local position estimate = (any) position estimate, since we never have a global estimate without a local one?
yes, then why not Navigation error: No valid position estimate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The messaging in case of estimation failures (local and global position, altitude) is very minimalistic and not end-user friendly.
Solution
This is how the notification would look like now:
Expanded event (with description):
This is the raw notification, that also pops up in yellow on screen:
Changelog Entry
For release notes: