Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform autocal with EKF mag bias estimate #23680

Draft
wants to merge 1 commit into
base: pr-ekf2_check_mag_field_with_bias
Choose a base branch
from

Conversation

bresch
Copy link
Member

@bresch bresch commented Sep 17, 2024

requires: #23584

Solved Problem

A separate magnetometer bias estimator was added as it was not safe to activate the mag bias estimation of earlier EKF2 versions. This is now solved and having 2 different estimator affecting the mag biases adds a lot of unnecessary complexity.

Solution

Use EKF2 mag bias estimates only (also for autocal).

Changelog Entry

For release notes:

New parameter: none (removed MBE_ENABLE and MBE_LEARN_GAIN)
Documentation: TBD

Test coverage

Tested on a Pixhawk 4 (internal mag only).
Left: autocal using EKF2 mag bias estimate ----------------- Right: 6-sides calibration
image

Remove separate mag bias estimator
@bresch bresch requested a review from dagar September 17, 2024 12:16
@bresch bresch self-assigned this Sep 17, 2024
@dagar
Copy link
Member

dagar commented Sep 23, 2024

This might be controversial, but I think we should keep the possibility to establish an initial mag cal (entirely preflight) if mag is completely uncalibrated. It could be sufficiently strict so that regular users don't accidentally slip through and avoid the full mag cal dance, but I think it's a nice convenience for bench testing. I think we can be sufficiently strict so that you actually have to wave things around and get a decent bias estimate or perhaps hide this behind a parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants