Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh::gh NA_character token; r4ss 1.49.3 dependency #111

Merged
merged 3 commits into from
Nov 16, 2024
Merged

gh::gh NA_character token; r4ss 1.49.3 dependency #111

merged 3 commits into from
Nov 16, 2024

Conversation

efletcherPIFSC
Copy link
Collaborator

Resolves #109 and #110

  • Change r4ss dependency r4ss to version 1.49.3 for compatibility. r4ss 1.50.0 introduces a major changes to its read/write functions, but breaks compatibility with existing ss3diags functions.
  • Added local get_ss3_exe function, based on r4ss::get_ss3_exe(),

@efletcherPIFSC efletcherPIFSC added topic: test workflow For automated testing (github actions) and testthat topic: Stock-Synthesis Specific for Stock-Synthesis Models or its functionality labels Nov 16, 2024
@efletcherPIFSC efletcherPIFSC merged commit fb78e74 into main Nov 16, 2024
@efletcherPIFSC efletcherPIFSC linked an issue Nov 16, 2024 that may be closed by this pull request
Local get_ss3_exe w/ gh::gh() token fix (refactor get_ss3_exe if-else platform/os) #110
Closed
@efletcherPIFSC efletcherPIFSC deleted the fix-109-r4ss-dependency branch November 19, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: Stock-Synthesis Specific for Stock-Synthesis Models or its functionality topic: test workflow For automated testing (github actions) and testthat
Projects
ss3diags dev project
Status: Done
Milestone
No milestone
1 participant
@efletcherPIFSC