You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If r_arch is 32-bit then warn user "(Windows) 32-bit Stock Synthesis executable isn't available"
else download the target version (tag) of Stock Synthesis windows binary (ss3_win.exe) from nmfs-ost/ss3-source-code
else
If (the first 6 characters of) R.versionos matches "darwin" and R.versionarch is "aarch64" then download the target version (tag) of Stock Synthesis binary (ss3_osx_arm64.exe) from nmfs-ost/ss3-source-code
else
If (the first 6 characters of) R.versionos matches "darwin" and R.versionarch is "x86_64" then download the target version (tag) of Stock Synthesis binary (ss3_osx.exe) from nmfs-ost/ss3-source-code
else
If .PlatformOS.type is linux-gnu then download the target version tag of Stock Synthesis binary (ss3_linux) from nmfs-ost/ss3-source-code
else throw ss3 not available for platform error
Possible Solution
Unify control statements using R.version stating:
match mingw32 for windows
macOS: Check R.version$os the first 6 characters matches "darwin"
match linux-gnu for linux
throw error for other matchers
IF Windows
32-bit check
get ss3_win.exe
ELSE IF "darwin" (macOS)
ss3_osx_arm64.exe
ss3_osx.exe
ELSE IF "linux" get ss3_linux
ELSE error
The text was updated successfully, but these errors were encountered:
Fix nmfs-ost SAML auth issues with found with #109 to implement
r4ss::get_ss3_exe
withgh::gh
NA_character token fixCreate a local
get_ss3_exe
R script to maintain compatibility with r4ss 1.49.3 and implementgh::gh()
token issue fixes (#109 (comment))os/platform if-else control statement for r4ss/r4ss
get_ss3_exe
can be optimizedThe following the pseudo code for the if-else statement based on "current" implementation (at the time of issue was created) of get_ss3_exe
OS.type
iswindows
r_arch
is 32-bit then warn user "(Windows) 32-bit Stock Synthesis executable isn't available"os
matches "darwin" and R.versionarch
is "aarch64" then download the target version (tag) of Stock Synthesis binary (ss3_osx_arm64.exe) from nmfs-ost/ss3-source-codeos
matches "darwin" and R.versionarch
is "x86_64" then download the target version (tag) of Stock Synthesis binary (ss3_osx.exe) from nmfs-ost/ss3-source-codeOS.type
islinux-gnu
then download the target version tag of Stock Synthesis binary (ss3_linux) from nmfs-ost/ss3-source-codePossible Solution
Unify control statements using R.version stating:
mingw32
for windowsR.version$os
the first 6 characters matches "darwin"linux-gnu
for linuxThe text was updated successfully, but these errors were encountered: