Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: Various fixes #11333

Merged

Conversation

JordanTheToaster
Copy link
Member

@JordanTheToaster JordanTheToaster commented Jun 4, 2024

Description of Changes

Just a little fixing for bloom alignment now that Align To Native HPO is safer to use. Very nice.

Fixes #10936
Fixes #11386
Fixes #11389

Rationale behind Changes

Fix good.

Suggested Testing Steps

Make sure CI is happy boi.

@JordanTheToaster JordanTheToaster marked this pull request as draft June 4, 2024 11:11
@github-actions github-actions bot added the GameDB label Jun 4, 2024
@JordanTheToaster JordanTheToaster force-pushed the Would-You-Like-Some-Cheese branch 6 times, most recently from 2de3584 to 9673601 Compare June 11, 2024 02:14
@JordanTheToaster JordanTheToaster force-pushed the Would-You-Like-Some-Cheese branch 13 times, most recently from e5e851c to 5109282 Compare June 17, 2024 21:52
@DonelBueno
Copy link

DonelBueno commented Jun 18, 2024

May I suggest some changes to the GameDB on this PR?

NFS: Hot Pursuit 2 (Recommend High Blending)
Medium Blending:
1

High Blending:
2

Software:
3

Jak 3 (Recommend High Blending, affects the pause menu and the press start screen, probably more)
Medium Blending:
PCSX2_2024_06_18_02_38_38_241
PCSX2_2024_06_18_02_44_29_664

High Blending:
PCSX2_2024_06_18_02_43_23_310
PCSX2_2024_06_18_02_44_36_854

Software:
PCSX2_2024_06_18_02_43_42_700
PCSX2_2024_06_18_02_44_25_177

Sega Rally 2006 (Remove Blending Recommendation)
Minimum Blending:
PCSX2_2024_06_18_02_39_52_682

Maximum Blending:
PCSX2_2024_06_18_02_39_36_966

Software:
PCSX2_2024_06_18_02_39_58_255

Virtua Racing (Add Round Sprite Full)
Master:
PCSX2_2024_06_18_02_52_56_201

Round Sprite Full:
PCSX2_2024_06_18_02_56_51_258

Software:
PCSX2_2024_06_18_02_53_24_686

TimeSplitters - Future Perfect (Add Round Sprite Full, fixes crosshair doubling and aligns bloom a little better)
Master:
PCSX2_2024_06_18_03_13_59_594

Round Sprite Full:
PCSX2_2024_06_18_03_13_56_477

Software:
PCSX2_2024_06_18_03_14_01_696

Dragon Quest VIII (Change HPO from 2 to 4 and RSO from 1 to 2 - Fixes black lines and aligns shadows better)
Master (HPO Special (Texture) + Round Sprite Half):
1- Master

HPO Allign To Native + Round Sprite Full:
2- HPO 4 + RSO 2

Software:
3- Software

@bigol83
Copy link

bigol83 commented Jun 18, 2024

Dragon Quest VIII with HPO to Native and Round Sprite to Full give main character hair red outlines. Even just RS to Full still gives main character red outlines.

Dragon Quest VIII - Journey of the Cursed King_SLES-53974_20240618113511
Dragon Quest VIII - Journey of the Cursed King_SLES-53974_20240618113511.gs.zip

Actually the only way to make shadows better and remove right side lines without side effects is with Native Scaling at Aggressive but it has that issue that transitioning from overworld camera to battle camera it all becomes pixelated.

@DonelBueno
Copy link

DonelBueno commented Jun 18, 2024

Dragon Quest VIII with HPO to Native and Round Sprite to Full give main character hair red outlines. Even just RS to Full still gives main character red outlines.

That's unfortunate. Well, at least HPO align to native seems to be a modest improvement over master and not cause negative effects. Anyway, I honestly think these red outlines are less distracting than the black lines, but of course that's subjective.

@bigol83
Copy link

bigol83 commented Jun 18, 2024

Align to Native alone has the red oulines on the hair, too. Considering that @refractionpcsx2 fixed Valkyrie Profile going pixelated after camera transitions, i wonder if Dragon Quest VIII being pixelated on camera change can be fixed too. Aggressive Native Scaling actually is the only real solution to the right side lines without any side effects whatsoever.
I know he said he didn't like the way character black outlines became too thick with Aggressive Native Scaling, but that would easily be the less distracting issue and the best outcome in my opinion.

This is with just Align to Native

Dragon Quest VIII - Journey of the Cursed King_SLES-53974_20240618135548

@JordanTheToaster JordanTheToaster force-pushed the Would-You-Like-Some-Cheese branch 2 times, most recently from 99d0bf4 to 99da3a4 Compare June 18, 2024 12:06
@JordanTheToaster
Copy link
Member Author

JordanTheToaster commented Jun 18, 2024

Virtua Racing

Not a fan of adding RS Full to TS2 and DQ8 has aforementioned issues but I've added everything else.

@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Jun 18, 2024

DQ8 negative effects from Align to Native (look at the water)

image

and full round kinda breaks the position of the post lighting on the sword in this scene (not that it's great.)

@refractionpcsx2
Copy link
Member

As for the pixelation, it still happens, that PR wasn't a magic bullet, unfortunately.

image

Here's the dump if you wanna try it yourself
Dragon Quest VIII - Journey of the Cursed King_SLES-53974_20230303225648.gs.zip

@crashGG
Copy link
Contributor

crashGG commented Jun 21, 2024

Another Century’s Episode 3 THE FINAL
master:
strong flickering on the title screen when use Hardware Rendering
software:
Another Century's Episode 3 - The Final_SLPS-25784_20240621092730

pr:
change deinterlacing : 6
no more flickering, but the brightness of the game screen is halved.
Another Century's Episode 3 - The Final_SLPS-25784_20240621092839

but with this fix
gameFixes:
- SoftwareRendererFMVHack
See here:#11434
The issue is basically solved.

@JordanTheToaster JordanTheToaster force-pushed the Would-You-Like-Some-Cheese branch 2 times, most recently from a5df8b3 to 9d9f2ab Compare June 21, 2024 18:04
@JordanTheToaster
Copy link
Member Author

but with this fix gameFixes: - SoftwareRendererFMVHack See here:#11434 The issue is basically solved.

Looks fine here?

image

@crashGG
Copy link
Contributor

crashGG commented Jun 21, 2024

but with this fix gameFixes: - SoftwareRendererFMVHack See here:#11434 The issue is basically solved.

Looks fine here?

image

Fine. Except for the flickering for a few seconds when the game starts, the game screen is normal afterwards. Switching SoftwareRendererFMV seems to be the best stopgap solution until a better way is found.

In addition, I applied No-Interlacing Patches by default.

@JordanTheToaster JordanTheToaster force-pushed the Would-You-Like-Some-Cheese branch 5 times, most recently from 65d50bc to b996f93 Compare June 23, 2024 01:52
@crashGG
Copy link
Contributor

crashGG commented Jun 23, 2024

but with this fix gameFixes: - SoftwareRendererFMVHack See here:#11434 The issue is basically solved.

Looks fine here?

image

The new master build 5921 has solved this issue

@JordanTheToaster JordanTheToaster force-pushed the Would-You-Like-Some-Cheese branch 14 times, most recently from f9f17d1 to d47fdc0 Compare June 25, 2024 00:12
@JordanTheToaster JordanTheToaster force-pushed the Would-You-Like-Some-Cheese branch from d47fdc0 to d271060 Compare June 25, 2024 02:39
@JordanTheToaster JordanTheToaster marked this pull request as ready for review June 25, 2024 02:41
@refractionpcsx2 refractionpcsx2 merged commit f8ab384 into PCSX2:master Jun 25, 2024
13 checks passed
@JordanTheToaster JordanTheToaster deleted the Would-You-Like-Some-Cheese branch June 25, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants