GS/HW: Add support for blend second pass for hw blending. #10994
Conversation
github-actions
bot
added
GS
GS: Hardware
GS: Direct3D 11
GS: OpenGL
GS: Vulkan
GS: Direct3D 12
GS: Metal
labels
|
This fixes the black spots in forest on Dx11. at basic blending too.
Great job. It's not at Vulkan and Opengl level but it's a big improvement. Will check more later. |
Nah that was an error, had a condition inverted so this won't be affected once I update the pr. |
lightningterror
force-pushed
the
gs_blend_second_pass
branch
6 times, most recently
from
8fedbad to
b5d0104
Compare
|
Will this PR match the Direct3D blending to the blending of Vulkan (Blending Level High) and the Software renderer for Knight Rider - The Game? Single Frame GS-Dump: |
No |
lightningterror
force-pushed
the
gs_blend_second_pass
branch
from
b5d0104 to
c81cd5a
Compare
lightningterror
force-pushed
the
gs_blend_second_pass
branch
3 times, most recently
from
1c9f62f to
a4af461
Compare
lightningterror
force-pushed
the
gs_blend_second_pass
branch
2 times, most recently
from
9f455a0 to
fdb9d41
Compare
lightningterror
force-pushed
the
gs_blend_second_pass
branch
2 times, most recently
from
f5fbb84 to
386b8fb
Compare
lightningterror
force-pushed
the
gs_blend_second_pass
branch
4 times, most recently
from
b9f64eb to
f3adc6b
Compare
lightningterror
requested review from
kamfretoz,
JordanTheToaster and
stenzek
and removed request for
kamfretoz and
JordanTheToaster
lightningterror
force-pushed
the
gs_blend_second_pass
branch
from
f3adc6b to
b6ccb0a
Compare
Allows us to blend Cd with full alpha range of 0-2 bypassing hw blend limitations. Not all Cd cases are covered, but it's a good start. Also allows us to do Ad cases where we can double the blend to get the proper blend result since Ad range is 0-1 instead of 0-2.
lightningterror
force-pushed
the
gs_blend_second_pass
branch
from
b6ccb0a to
51373f8
Compare
|
This PR fixed #11001 |
Description of Changes
Allows us to blend Cd with alpha range of 0-2 instead of 0-1. Not all Cd cases are covered, but it's a good start.
Second best scenario, something between sw rendering and previous hw rendering, there may be a slight performance impact, but nothing like reading the framebuffer.
Also allows us to do Ad cases where we can double the blend to get the
proper blend result since Ad range is 0-1 instead of 0-2.
Rationale behind Changes
Make hw blending suck even less, will help Direct3D.
Suggested Testing Steps
Test various of games that previously were broken on Direct3D or needed higher blending on Direct3D.
This won't affect Vk/GL unless we turn off barriers, so the same games can be smoke test on them just to know nothing broke.
There's 2 dumps I need to check and make sure they aren't actually broken so don't merge, image comparisons of fixes soon™.
Eye candy comparisons, DX basic blend: