GS/TC: Remove old targets when changing width and outside a page #10470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamfretoz
approved these changes
Dec 25, 2023
refractionpcsx2
force-pushed
the
gs_removeoldtarget
branch
from
5f8e883 to
0ebb0ee
Compare
refractionpcsx2
force-pushed
the
gs_removeoldtarget
branch
from
0ebb0ee to
e0b8260
Compare
JordanTheToaster
approved these changes
Dec 26, 2023
kamfretoz
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removes old targets if the width changes and is drawing outside the height of a page, if it's not a clear and the target is dirty.
Rationale behind Changes
In this scenario, the likelyhood is the target is changing to something new, which was the case with Medal of Honor, causing the texture to be the wrong shape, which can mess up the rendering. The only other solution would be for us to rearrange targets on width change, but we don't do this currently.
Suggested Testing Steps
Test some random games and Medal of Honor - European Assault
Medal of Honor - European Assault:
Master:
PR: