-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add q
(streamflow) to variables.yml
#1996
Conversation
But if |
I just thought that the variable associated with the streamflow should have its standard naming declared with units in |
Most references to I think my point is that such a breaking change doesn't seem justified if it is not based on convention. |
strf
instead of q
as a variableq
(streamflow) to variables.yml
Ok, I've just replaced the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't see that you had requested a review from me!
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
q
as a proper variable in variables.ymlDoes this PR introduce a breaking change?
No
Other information:
Discussing with @RondeauG , we were deliberating between
qstr
,qstrm
,strf
. I haven't seen any of these variables in many places in litterature, there doesn't seem to be a standard abbreviation apart fromQ
orq
(flow or specific flow ), so I'm enclined to changestrf
if it doesn't feel right.