Skip to content

Commit

Permalink
Add q (streamflow) to variables.yml (#1996)
Browse files Browse the repository at this point in the history
<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* Add `q` as a proper variable in variables.yml

### Does this PR introduce a breaking change?

No

### Other information:

Discussing with @RondeauG , we were deliberating between `qstr`,
`qstrm`, `strf`. I haven't seen any of these variables in many places in
litterature, there doesn't seem to be a standard abbreviation apart from
`Q` or `q` (flow or specific flow ), so I'm enclined to change `strf` if
it doesn't feel right.
  • Loading branch information
coxipi authored Nov 22, 2024
2 parents abcf682 + b4c6218 commit 75c0d11
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Changelog

v0.54.0 (unreleased)
--------------------
Contributors to this version: Trevor James Smith (:user:`Zeitsperre`), Pascal Bourgault (:user:`aulemahal`).
Contributors to this version: Trevor James Smith (:user:`Zeitsperre`), Pascal Bourgault (:user:`aulemahal`), Éric Dupuis (:user:`coxipi`).

Breaking changes
^^^^^^^^^^^^^^^^
Expand All @@ -20,6 +20,7 @@ Bug fixes
Internal changes
^^^^^^^^^^^^^^^^
* Changed french translations with word "pluvieux" to "avec précipitations". (:issue:`1960`, :pull:`1994`).
* `streamflow` entry replaced with `q` in ``variables.yml``. (:issue:`1912`, :pull:`1996`)
* In order to address 403 (forbidden) request errors when retrieving data from GitHub via ReadTheDocs, the ``nimbus`` class has been modified to use an overloaded `fetch` method that appends a User-Agent header to the request. (:pull:`2001`).
* Addressed a very rare race condition that can happen if `pytest` is tearing down the test environment when running across multiple workers. (:pull:`1863`).

Expand Down
2 changes: 1 addition & 1 deletion xclim/data/variables.yml
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ variables:
standard_name: lwe_thickness_of_snow_amount
data_flags:
- negative_accumulation_values:
streamflow:
q:
canonical_units: m3 s-1
cell_methods: "time: mean"
description: The amount of water, in all phases, flowing in the river channel and flood plain.
Expand Down

0 comments on commit 75c0d11

Please sign in to comment.