-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(L-02): Inconsistent Implementations in ERC-721 Extension #331 #333
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b54a2fc
fix(L-02): mismatch in Erc721 Metadata extension
bidzyyys 6af6985
fix(L-02): inconsistency in Erc721 URIStorage extension
bidzyyys 617e856
Merge branch 'v0.1.0' into bidzyyys/fix-L-02
bidzyyys afdeba1
test: fix E2E tests
bidzyyys 7e6c7b8
wip: unit tests for Erc721 UriStorage compile
bidzyyys 40bf02e
Merge branch 'v0.1.0' into bidzyyys/fix-L-02
bidzyyys 6a12dcb
Merge branch 'v0.1.0' into bidzyyys/fix-L-02
bidzyyys 4947f08
fix tests
qalisander ce7a85c
add ERC165 support interface to IErc721Metadata
qalisander 30beeae
++
qalisander 2a39049
++
qalisander 14643a3
Merge branch 'v0.1.0' into bidzyyys/fix-L-02
bidzyyys 672a8a1
Merge branch 'v0.1.0' into bidzyyys/fix-L-02
bidzyyys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case
#[interface_id]
won't be that helpful. Because methods insideIErc721Metadata
trait are not same as in solidity (token_uri
is missing). So computed interface id will be different..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the only thing preventing this PR I would say we don't expose
#[interface_id]
for the metadata extension(since I don't think it is part of the EIP itself).One thing we should do is add in the Anotra docs or at the top of the contract that people should expose
token_uri
manually(I know it is on the internal function description, but still)