fix(L-02): Inconsistent Implementations in ERC-721 Extension #331 #333
Conversation
|
|
||
| fn base_uri(&self) -> String { |
There was a problem hiding this comment.
In this case #[interface_id] won't be that helpful. Because methods inside IErc721Metadata trait are not same as in solidity (token_uri is missing). So computed interface id will be different..
There was a problem hiding this comment.
If this is the only thing preventing this PR I would say we don't expose #[interface_id] for the metadata extension(since I don't think it is part of the EIP itself).
One thing we should do is add in the Anotra docs or at the top of the contract that people should expose token_uri manually(I know it is on the internal function description, but still)
|
|
||
| fn base_uri(&self) -> String { |
There was a problem hiding this comment.
If this is the only thing preventing this PR I would say we don't expose #[interface_id] for the metadata extension(since I don't think it is part of the EIP itself).
One thing we should do is add in the Anotra docs or at the top of the contract that people should expose token_uri manually(I know it is on the internal function description, but still)
Resolves #312