fix(critical-error): critical-error pass early then trap #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lewislzh
commented
Nov 18, 2024
lewislzh
commented
- critical-error diff REF as xiangshan pass criticial-error too early
- bump difftest to make critical_error more prominent
lewislzh
force-pushed
the
fix-critical-error
branch
from
0d38c39
to
9c2c99a
Compare
* critical-error diff REF as xiangshan pass criticial-error too early * bump difftest to make critical_error more prominent
wissygh
approved these changes
Nov 18, 2024
Tang-Haojin
approved these changes
Nov 19, 2024
wissygh
added
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.