Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: src rx st20 plugin for gstreamer #1026

Merged

Conversation

DawidWesierski4
Copy link
Collaborator

Create a plugin for st20p rx standard
for GStreamer, allowing to receive the data in the
pipeline mode.

Create a simple design where we create
the session in the _start function,
receive and process in _create function.

Move some of the functions from the TX to the
common file.

Change the name of the TX plugin to mtl_st20p_tx to
make it easier to distinguish between the plugins.

Create a plugin for st20p rx standard
for gstreamer, allowing to receive the data in the
pipeline mode.

Create a simple design where we create
the session in the _start function, and
the recive and processing is in _create function.

Move some of the functions from the TX RX to the
common file.
Change the name of TX plugin to mtl_st20p_tx to
make it easier to distiguish between the plugins.
@DawidWesierski4
Copy link
Collaborator Author

Known issue
image

TODO:s

Support for shared MTL handle in pipeline @Sakoram seems to have some idea for implementation of that

Support for redundancy (better to have a single port parser that will fit our needs so we will probably do that when st30 tx will be here )

Copy link
Collaborator

@skolelis skolelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ecosystem/gstreamer_plugin/gst_mtl_common.c Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_st20p_tx.c Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c Show resolved Hide resolved
@DawidWesierski4 DawidWesierski4 changed the title Add: prototype src rx st20 plugin for gstreamer Add: src rx st20 plugin for gstreamer Jan 2, 2025
Copy link
Collaborator Author

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sakoram please take a second look

I ironed out the quirks add some sort of synchronization but kinda can't test it yet as i have no testing cases without the another RX but we will cross that bridge when we will get to it

ecosystem/gstreamer_plugin/gst_mtl_common.c Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_common.c Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c Outdated Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c Show resolved Hide resolved
ecosystem/gstreamer_plugin/gst_mtl_st20p_rx.c Show resolved Hide resolved
Syntax changes, fixing a bug where where 422
format was treated as 420.
Syntax changes.
Fix bug with shift in buffer.
Fix bug with last 3 frames being stopped.
@DawidWesierski4 DawidWesierski4 merged commit a698766 into OpenVisualCloud:main Jan 7, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants