Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siprec: fill stream object in metadata #3293

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/build-contrib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ github_handles=(
["Sergey Khripchenko"]="shripchenko"
["Stefan Pologov"]="sisoftrg"
["Stéphane Alnet"]="shimaore"
["Seyed Mehran Siadati"]="siadatism"
["Victor Ciurel <[email protected]>"]="victor-ciurel"
["Vlad Paiu"]="vladpaiu"
["Vlad Patrascu"]="rvlad-patrascu"
Expand Down
21 changes: 20 additions & 1 deletion modules/siprec/siprec.c
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,17 @@ static int siprec_start_rec(struct sip_msg *msg, str *srs)
LM_ERR("cannot add caller participant!\n");
goto session_cleanup;
}
/* caller info */

siprec_uuid caller_uuid;
siprec_build_uuid(caller_uuid);
int caller_label = 0;
int caller_medianum = 0;
if (srs_add_raw_sdp_stream(caller_label, caller_medianum, &caller_uuid, ss, &ss->participants[0]) < 0) {
LM_ERR("cannot add new media stream!\n");
goto session_cleanup;
}

/* callee info */
if (var && var->callee.len) {
xml_val = &var->callee;
} else {
Expand All @@ -266,6 +276,15 @@ static int siprec_start_rec(struct sip_msg *msg, str *srs)
goto session_cleanup;
}

siprec_uuid callee_uuid;
siprec_build_uuid(callee_uuid);
int callee_label = 1;
int callee_medianum = 0;
if (srs_add_raw_sdp_stream(callee_label, callee_medianum, &callee_uuid, ss, &ss->participants[1]) < 0) {
LM_ERR("cannot add new media stream!\n");
goto session_cleanup;
}

SIPREC_REF_UNSAFE(ss);
srec_hlog(ss, SREC_REF, "starting recording");
if (srec_tm.register_tmcb(msg, 0, TMCB_RESPONSE_OUT, tm_start_recording,
Expand Down
1 change: 0 additions & 1 deletion modules/siprec/siprec_logic.c
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,6 @@ int srs_handle_media(struct sip_msg *msg, struct src_sess *sess)
return 0;
}


static void srs_send_update_invite(struct src_sess *sess, str *body)
{
struct b2b_req_data req;
Expand Down
Loading