siprec: fill stream object in metadata #3293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am afraid this is not the correct approach, as you cannot make the index assumptions you made - in fact, rtpproxy does them differently than rtpengine :). So you can't rely on that, we need to "learn" it somehow, either by provided by the media relay, either by parsing the SDP. |
|
Thank you for your response, @razvancrainea. Is it feasible to differentiate between the caller's and the callee's streams by parsing the SDP? If so, which specific field in the SDP indicates this difference? |
|
@razvancrainea any update? we need this feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently stream object in not exists in generated metadata in SIPREC sessions. This PR is aiming to fill this object so it could be added in metadata.
Details
SIPREC metadata includes stream object to identify owner of each stream by adding its label.
Additional information is provided in feature request #3287.
Solution
The stream object is already implemented but it is not being filled. For each stream, an stream uuid should be generated, and its label should be extracted from SDP. My current solution is primitive, it assumes the caller's stream label is 0 and the callee's stream label is 1. I don't know if this assumption is current in all cases or not. Someone else's opinion would be great.
Compatibility
No compatibility problem should be observed.
Closing issues
Closes #3287.