Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: target_file_size_base connot set large than 2G #2880

Merged
merged 2 commits into from
Aug 23, 2024
Merged

fix: target_file_size_base connot set large than 2G #2880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d42a27f
target_file_size_base_ to int64_t
007gzs Aug 21, 2024
09bc481
GetConfInt64Human
007gzs Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/pika_conf.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ class PikaConf : public pstd::BaseConf {
std::shared_lock l(rwlock_);
return compression_;
}
int target_file_size_base() {
int64_t target_file_size_base() {
std::shared_lock l(rwlock_);
return target_file_size_base_;
}
Expand Down Expand Up @@ -1027,7 +1027,7 @@ class PikaConf : public pstd::BaseConf {
// Critical configure items
//
bool write_binlog_ = false;
int target_file_size_base_ = 0;
int64_t target_file_size_base_ = 0;
int64_t max_compaction_bytes_ = 0;
int binlog_file_size_ = 0;

Expand Down
2 changes: 1 addition & 1 deletion src/pika_conf.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ int PikaConf::Load() {
}

// target_file_size_base
GetConfIntHuman("target-file-size-base", &target_file_size_base_);
GetConfInt64Human("target-file-size-base", &target_file_size_base_);
if (target_file_size_base_ <= 0) {
target_file_size_base_ = 1048576; // 10Mb
}
Expand Down
Loading