fix: target_file_size_base connot set large than 2G #2880
Conversation
WalkthroughThe changes enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- include/pika_conf.h (2 hunks)
- src/pika_conf.cc (1 hunks)
Additional comments not posted (2)
src/pika_conf.cc (1)
424-424: Verify the usage ofGetConfInt64Human.Ensure that the function
GetConfInt64Humanis correctly implemented and used elsewhere in the codebase. It should handle 64-bit integers appropriately.Run the following script to verify the implementation and usage of
GetConfInt64Human:Verification successful
GetConfInt64Humanis correctly implemented and usedThe function
GetConfInt64Humanis defined to handle 64-bit integers and is used appropriately throughout the codebase to retrieve configuration values intoint64_tvariables.
- Definition: Found in
src/pstd/src/base_conf.cc.- Declaration: Found in
src/pstd/include/base_conf.h.- Usages: Multiple instances in
src/pika_conf.cc.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the implementation and usage of `GetConfInt64Human`. # Test: Search for the function definition and its usage. Expect: Correct handling of int64_t. ast-grep --lang cpp --pattern $'GetConfInt64Human($_, $_)' --debug-queryLength of output: 127
Script:
#!/bin/bash # Search for the definition of `GetConfInt64Human` in the codebase. ast-grep --lang cpp --pattern 'int64_t GetConfInt64Human($_, $_) { $$$ }' # Search for all usages of `GetConfInt64Human` in the codebase. rg 'GetConfInt64Human' -A 3Length of output: 3464
include/pika_conf.h (1)
273-273: Verify consistency ofint64_tusage.Ensure that the change from
inttoint64_tfortarget_file_size_base_and its getter method is consistently applied across the codebase.Run the following script to verify the consistency of
int64_tusage fortarget_file_size_base_:Also applies to: 1030-1030
Verification successful
Consistent
int64_tUsage fortarget_file_size_base_The change from
inttoint64_tfortarget_file_size_base_and its getter method is consistently applied across the codebase. The occurrences ininclude/pika_conf.handsrc/pika_conf.ccconfirm this consistency.
include/pika_conf.h: Declaration asint64_t.src/pika_conf.cc: Usage aligns withint64_t.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency of `int64_t` usage for `target_file_size_base_`. # Test: Search for all occurrences of `target_file_size_base_`. Expect: Consistent use of `int64_t`. rg --type cpp -A 2 $'target_file_size_base_'Length of output: 747
007gzs
changed the title
007gzs
changed the title
…on#2880) * target_file_size_base_ to int64_t
目前target_file_size_base类型是int, 设置超过2G会变成10M
pika/src/storage/src/options_helper.h
Line 54 in 3a232f2
按照这里的说明类型应该是int64的
Summary by CodeRabbit
New Features
Bug Fixes
Documentation