-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Enforce linting and prettier rules #1103
Merged
Merged
Commits on Aug 25, 2023
-
stop allowing lint to pass with errors
We should fail on lint errors, then we can follow up in another commit fixing these errors as part of a PR to enforce the rules.
Configuration menu - View commit details
-
Copy full SHA for b1e8140 - Browse repository at this point
Copy the full SHA b1e8140View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b927bd - Browse repository at this point
Copy the full SHA 6b927bdView commit details -
This commit is large since eslit --fix was run to auto fix most issues. Some that did not have auto fixes were done manually. Some changes were not made as they were too risky to change so instead some in-line comments were used to suppress them. This was preferred over globally turning off the rule, as keeping it on means new code has to follow the rule.
Configuration menu - View commit details
-
Copy full SHA for 92e5d2a - Browse repository at this point
Copy the full SHA 92e5d2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 026e98e - Browse repository at this point
Copy the full SHA 026e98eView commit details -
Apply prettier formatting rules to all code
Ran yarn prettier --write src test __test__
Configuration menu - View commit details
-
Copy full SHA for 090067c - Browse repository at this point
Copy the full SHA 090067cView commit details -
Configuration menu - View commit details
-
Copy full SHA for af5c3d7 - Browse repository at this point
Copy the full SHA af5c3d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for efaf053 - Browse repository at this point
Copy the full SHA efaf053View commit details
Commits on Aug 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 543f21a - Browse repository at this point
Copy the full SHA 543f21aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96861e9 - Browse repository at this point
Copy the full SHA 96861e9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.