Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Enforce linting and prettier rules #1103

Merged
merged 9 commits into from
Aug 31, 2023
Merged

[CI] Enforce linting and prettier rules #1103

merged 9 commits into from
Aug 31, 2023

Commits on Aug 25, 2023

  1. stop allowing lint to pass with errors

    We should fail on lint errors, then we can follow up in another commit
    fixing these errors as part of a PR to enforce the rules.
    jkasten2 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    b1e8140 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b927bd View commit details
    Browse the repository at this point in the history
  3. applied eslit --fix

    This commit is large since eslit --fix was run to auto fix most issues.
    Some that did not have auto fixes were done manually.
    
    Some changes were not made as they were too risky to change so instead
    some in-line comments were used to suppress them. This was preferred
    over globally turning off the rule, as keeping it on means new code has
    to follow the rule.
    jkasten2 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    92e5d2a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    026e98e View commit details
    Browse the repository at this point in the history
  5. Apply prettier formatting rules to all code

    Ran yarn prettier --write src test __test__
    jkasten2 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    090067c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    af5c3d7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    efaf053 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. fixup! applied eslit --fix

    jkasten2 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    543f21a View commit details
    Browse the repository at this point in the history
  2. fixup! applied eslit --fix

    jkasten2 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    96861e9 View commit details
    Browse the repository at this point in the history