[CI] Enforce linting and prettier rules #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should fail on lint errors, then we can follow up in another commit fixing these errors as part of a PR to enforce the rules.
This commit is large since eslit --fix was run to auto fix most issues. Some that did not have auto fixes were done manually. Some changes were not made as they were too risky to change so instead some in-line comments were used to suppress them. This was preferred over globally turning off the rule, as keeping it on means new code has to follow the rule.
Ran yarn prettier --write src test __test__
emawby
approved these changes
Aug 31, 2023
rgomezp
requested changes
Aug 31, 2023
rgomezp
requested changes
Aug 31, 2023
rgomezp
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Enable enforcement of eslint and prettier rules, as well as made the code changes required them to pass.
Details
Recommend reviewing commit-by-commit.
The following two commands were run on the source.
yarn prettier --write src test __test__yarn eslint src --ext .js,.jsx,.ts,.tsx --fixSince not all rules had auto fixes, some changes were done manually to meet the rules. Also a few in-line suppresses were added to since it was to risky to change the code at this time, but preferred over omitting the rule as the rule should still be applied to new code.
Validation
Tested on Windows 11 22H2 with Chrome 115.0.5790.171 ensuring it can subscribe, receive a push, register an email, and open a new tab on notification click.
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is