Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Passthrough params #708

Merged
merged 15 commits into from
Jan 24, 2024
Merged

Passthrough params #708

merged 15 commits into from
Jan 24, 2024

Conversation

pbrubeck
Copy link
Collaborator

No description provided.

@pbrubeck pbrubeck changed the title Connorjward/passthrough params Passthrough params Sep 21, 2023
connorjward
connorjward reviewed Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with this but I wrote all the code! We can review this on Wednesday.

@pbrubeck pbrubeck mentioned this pull request Jan 21, 2024
Merged
@pbrubeck pbrubeck requested a review from connorjward January 21, 2024 21:24
connorjward
connorjward approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon this is fine. It is a hack and not super well documented, but it should be straightforward (and cleaner) to make pyop3 handle this in the near future.

@dham dham merged commit e0a4d3a into master Jan 24, 2024
4 checks passed
@dham dham deleted the connorjward/passthrough-params branch January 24, 2024 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@connorjward connorjward connorjward approved these changes

@dham dham dham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbrubeck @dham @connorjward