-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FDMPC: generate pyop2 kernels #3341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work. I would like this to have a lot more documentation than it currently has.
Co-authored-by: Connor Ward <[email protected]>
pbrubeck
force-pushed
the
pbrubeck/fdm-pyop2-kernels
branch
4 times, most recently
from
February 16, 2024 09:58
4bb08e4
to
c29abf9
Compare
pbrubeck
force-pushed
the
pbrubeck/fdm-pyop2-kernels
branch
from
February 16, 2024 09:58
c29abf9
to
65551a7
Compare
connorjward
requested changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only some small comments, this looks pretty good
pbrubeck
commented
Feb 16, 2024
Co-authored-by: Connor Ward <[email protected]>
pbrubeck
force-pushed
the
pbrubeck/fdm-pyop2-kernels
branch
5 times, most recently
from
February 19, 2024 13:24
132ad98
to
49e1085
Compare
pbrubeck
force-pushed
the
pbrubeck/fdm-pyop2-kernels
branch
from
February 19, 2024 13:29
49e1085
to
8ee5a5d
Compare
dham
approved these changes
Feb 21, 2024
connorjward
approved these changes
Feb 21, 2024
JDBetteridge
pushed a commit
that referenced
this pull request
Mar 5, 2024
* FDMPC: generate pyop2 kernels --------- Co-authored-by: Connor Ward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, FDMPC assembly was done entirely with petsc4py calls inside python loops across the cells.
This PR implements the custom FDM assembly with pyop2 kernels.