Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDMPC: generate pyop2 kernels #3341

Merged
merged 12 commits into from
Feb 21, 2024
Merged

FDMPC: generate pyop2 kernels #3341

merged 12 commits into from
Feb 21, 2024

Conversation

pbrubeck
Copy link
Contributor

@pbrubeck pbrubeck commented Jan 21, 2024

Description

Previously, FDMPC assembly was done entirely with petsc4py calls inside python loops across the cells.
This PR implements the custom FDM assembly with pyop2 kernels.

@pbrubeck pbrubeck requested a review from connorjward January 21, 2024 21:24
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. I would like this to have a lot more documentation than it currently has.

firedrake/preconditioners/pmg.py Show resolved Hide resolved
firedrake/preconditioners/fdm.py Show resolved Hide resolved
firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
firedrake/preconditioners/fdm.py Show resolved Hide resolved
firedrake/preconditioners/fdm.py Show resolved Hide resolved
firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
firedrake/preconditioners/fdm.py Show resolved Hide resolved
firedrake/preconditioners/fdm.py Show resolved Hide resolved
firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
@pbrubeck pbrubeck force-pushed the pbrubeck/fdm-pyop2-kernels branch 4 times, most recently from 4bb08e4 to c29abf9 Compare February 16, 2024 09:58
@pbrubeck pbrubeck force-pushed the pbrubeck/fdm-pyop2-kernels branch from c29abf9 to 65551a7 Compare February 16, 2024 09:58
@pbrubeck pbrubeck requested a review from connorjward February 16, 2024 10:51
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only some small comments, this looks pretty good

firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
firedrake/preconditioners/fdm.py Show resolved Hide resolved
firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
firedrake/preconditioners/fdm.py Outdated Show resolved Hide resolved
@pbrubeck pbrubeck force-pushed the pbrubeck/fdm-pyop2-kernels branch 5 times, most recently from 132ad98 to 49e1085 Compare February 19, 2024 13:24
@pbrubeck pbrubeck force-pushed the pbrubeck/fdm-pyop2-kernels branch from 49e1085 to 8ee5a5d Compare February 19, 2024 13:29
@pbrubeck pbrubeck requested a review from connorjward February 19, 2024 15:41
@connorjward connorjward merged commit 5e1c62a into master Feb 21, 2024
10 checks passed
@connorjward connorjward deleted the pbrubeck/fdm-pyop2-kernels branch February 21, 2024 16:51
JDBetteridge pushed a commit that referenced this pull request Mar 5, 2024
* FDMPC: generate pyop2 kernels

---------

Co-authored-by: Connor Ward <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants